https://smaugmuds.afkmods.com/index.php?a=rssfeed&f=15 The largest Smaug community resource site. - Bugfixes for the AFKMud codebase will be posted here. These topics can only be edited or replied to by AFKMud Team members. en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/bug-compressend-does-not-free-up-the-mccp-buffer-if-data-fails-to-send-4368/&p=20374#p20374 Bug: compressEnd does not free up the MCCP buffer if data fails to send. Danger: Medium - If you have a lot of people using MCCP disconnecting regularly and not able to receive data, it leaks 4096 bytes every time that happens. Discovered in: AFKMud 2.1.3 Found by: Nick Gammon Fixed by: Nick Gammon --- [b]features.cpp, descriptor_data::compressEnd[/b] Locate: [code] if( deflate( mccp->out_compress, Z_FINISH ) != Z_STREAM_END ) return false; if( !process_compressed( https://smaugmuds.afkmods.com/topic/bug-compressend-does-not-free-up-the-mccp-buffer-if-data-fails-to-send-4368/&p=20374#p20374 Mon, 8 Mar 2010 01:46:19 CST AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-the-destroyimmdata-function-has-buffer-overflows-4367/&p=20373#p20373 Bug: The destroy_immdata function has buffer overflows. Danger: High - Very likely deleting an immortal from the game will result in a crash due to overflowed buffers. Discovered in: AFKMud 2.1.2 (delayed posting - already fixed in 2.1.3) Found by: apocalypticNRG Fixed by: Samson --- [b]act_wiz.cpp, destroy_immdata[/b] Locate: [code] char buf[256], buf2[256];[/code] Change to: [code] char buf[MSL], buf2[MSL];[/code] Well, that's embarrassing. these buffers were trying to https://smaugmuds.afkmods.com/topic/bug-the-destroyimmdata-function-has-buffer-overflows-4367/&p=20373#p20373 Mon, 8 Mar 2010 00:34:25 CST AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bugareas-area-conversion-fails-on-smaug-g-and-r-resets-4366/&p=20371#p20371 Bug: Area conversion fails on Smaug G and R resets. Danger: High - Area conversion fails, resulting in a crash. Discovered in: AFKMud 2.1.3 Found by: thindil Fixed by: thindil --- [b]areaconvert.cpp, load_stresets[/b] Locate: [code] int extra, arg1, arg2, arg3;[/code] Change to: [code] int extra, arg1, arg2, arg3 = 100;[/code] Locate: [code] arg3 = fread_number( fp );[/code] Change to: [code] if( letter != 'G' && letter != 'R' ) arg3 = frea https://smaugmuds.afkmods.com/topic/bugareas-area-conversion-fails-on-smaug-g-and-r-resets-4366/&p=20371#p20371 Sun, 7 Mar 2010 22:46:54 CST AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bugeditor-crash-when-clearing-an-existing-edit-buffer-4365/&p=20370#p20370 Bug: Crash when clearing an existing edit buffer. Danger: High - Potential for a lot of data loss if the crash happens during a long building session where work hasn't been saved. Discovered in: AFKMud 2.1.3 Found by: Materia Fixed by: Materia --- [b]editor.cpp, char_data::edit_buffer[/b] Locate: [code] if( !str_cmp( cmd, "c" ) ) { memset( edit, '\0', sizeof( editor_data ) ); edit->numlines = 0; edit->on_line = 0; print( "Buffer https://smaugmuds.afkmods.com/topic/bugeditor-crash-when-clearing-an-existing-edit-buffer-4365/&p=20370#p20370 Sun, 7 Mar 2010 21:52:47 CST AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bugeditor-crash-when-editing-a-multi-line-buffer-4364/&p=20368#p20368 Bug: Crash when editing a multi-line buffer. Danger: High - Potential for a lot of data loss if the crash happens during a long building session where work hasn't been saved. Discovered in: AFKMud 2.1.3 Found by: Materia Fixed by: Materia --- [b]editor.cpp[/b] Locate: [code]editor_data::editor_data( ) { init_memory( &line, &size, sizeof( size ) ); }[/code] Change to: [code]editor_data::editor_data( ) { init_memory( &line, &size, sizeof( size ) ); desc = ""; }[ https://smaugmuds.afkmods.com/topic/bugeditor-crash-when-editing-a-multi-line-buffer-4364/&p=20368#p20368 Sun, 7 Mar 2010 21:41:04 CST AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bughelps-help-file-keywords-are-case-sensitive-4363/&p=20367#p20367 Bug: Help file keywords are case sensitive. Danger: Trivial - Case sensitivity is annoying, not dangerous. Discovered in: AFKMud 2.1.3 Found by: tphegley, Quixadhal, and others Fixed by: Quixadhal --- [b]help.cpp[/b] Locate: [code]#include <fstream>[/code] Below that, add: [code]#include <algorithm>[/code] [b]help.cpp, load_helps[/b] Locate: [code] else if( key == "Keywords" ) { stream.getline( buf, MSL ); value = buf; strip_lspa https://smaugmuds.afkmods.com/topic/bughelps-help-file-keywords-are-case-sensitive-4363/&p=20367#p20367 Sun, 7 Mar 2010 21:03:27 CST AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-substate-commands-do-not-work-4053/&p=17746#p17746 Bug: Substate commands do not work Danger: High - Blocks all attempts at user input once the substate is locked. Discovered in: AFKMud 2.1.1 Found by: tphegley Fixed by: Samson --- [b]commands.cpp, interpret[/b] Locate: [code] /* * yes... we lose out on the hashing speediness here... * but the only REPEATCMDS are wizcommands (currently) */ for( char x = 0; x < 126; ++x ) { const vector < cmd_type * >&cmd_list https://smaugmuds.afkmods.com/topic/bug-substate-commands-do-not-work-4053/&p=17746#p17746 Fri, 22 May 2009 00:01:30 CDT AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-array-boundary-exceeded-during-socket-buffer-flush-3805/&p=15957#p15957 Bug: Array boundary exceeded during socket buffer flush Danger: High, with critical potential. Possible crashes or memory corruption due to array boundary overflow. Discovered in: AFKMud 2.1 Found by: GCC 4.3 Fixed by: Samson --- [b]descriptor.cpp, descriptor_data::flush_buffer[/b] Locate: [code] buf[4096] = '\0';[/code] Change to: [code] buf[4095] = '\0';[/code] GCC 4.3 issues the following warning: [quote]descriptor.cpp: In member function 'bool descriptor https://smaugmuds.afkmods.com/topic/bug-array-boundary-exceeded-during-socket-buffer-flush-3805/&p=15957#p15957 Sun, 5 Oct 2008 21:34:29 CDT AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-copyzone-command-checks-the-wrong-set-of-areas-by-default-3640/&p=14707#p14707 Bug: Copyzone command checks the wrong set of areas by default Danger: Low - The command will simply fail if the wrong area names are checked. Discovered in: AFKMud 2.03 Found by: Samson Fixed by: Samson --- [b]shell.cpp, do_copyzone[/b] Locate: [code] if( !str_cmp( argument, "gods.are" ) ) fname2 = "gods.are"; if( !str_cmp( argument, "bywater.are" ) ) fname2 = "bywater.are"; if( !str_cmp( argument, "entry.are" ) ) fname2 = "entry.ar https://smaugmuds.afkmods.com/topic/bug-copyzone-command-checks-the-wrong-set-of-areas-by-default-3640/&p=14707#p14707 Sun, 9 Mar 2008 13:06:55 CDT AFKMud Bugfix List nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-somewhere-exits-are-not-always-handled-right-by-getdir-3627/&p=14593#p14593 Bug: Somewhere exits are not always handled right by get_dir Danger: Low - This requires a very specific usage of the redit command before the issue shows itself. Discovered in: AFKMud 2.03 Found by: Remcon Fixed by: Remcon --- [b]build.cpp, get_dir[/b] Locate: [code] case 'e': case '1': edir = DIR_EAST; break; /* east */[/code] Change to: [code] case 'e': case '1': if( c2 == '0' ) edir = DIR_SOMEWHERE; https://smaugmuds.afkmods.com/topic/bug-somewhere-exits-are-not-always-handled-right-by-getdir-3627/&p=14593#p14593 Thu, 21 Feb 2008 23:41:24 CST AFKMud Bugfix List nobody@example.com (Samson)