https://smaugmuds.afkmods.com/index.php?a=rssfeed&f=22 The largest Smaug community resource site. - Archived bug fixes for the 1.x development tree. This code tree is permanently frozen at version 1.8. All future development continues on the C++ tree. en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/bug-ask-command-has-global-scope-1282/&p=4800#p4800 Bug: Ask command has global scope Danger: Low - Target for the ask command can be chosen from anywhere in the game. Discovered in: AFKMud 1.77 Found by: Conner Fixed by: Samson --- [b]act_comm.c, do_ask[/b] Locate: [code] if( ( victim = get_char_world( ch, arg ) ) == NULL || ( IS_NPC( victim ) && victim->in_room != ch->in_room ) ) { send_to_char( "They aren't here.\n\r", ch ); return; } [/code] Change to: [code] if( ( victim = get_char_room( ch, a https://smaugmuds.afkmods.com/topic/bug-ask-command-has-global-scope-1282/&p=4800#p4800 Sun, 3 Dec 2006 01:07:26 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-old-ibuild-code-chunks-cause-crashes-when-called-from-redit-1281/&p=4799#p4799 Bug: Old ibuild code chunks cause crashes when called from redit Danger: High - Crash condition. Orphaned code which should have been deleted a long time ago. Discovered in: AFKMud 1.77 Found by: Samson Fixed by: Samson/Remcon --- [b]build.c, do_redit[/b] Find and remove: [code] if( !str_cmp( arg, "ex_flags" ) ) { argument = one_argument( argument, arg2 ); value = get_exflag( arg2 ); if( value < 0 ) { send_to_char( "Bad exit flag. \r\ https://smaugmuds.afkmods.com/topic/bug-old-ibuild-code-chunks-cause-crashes-when-called-from-redit-1281/&p=4799#p4799 Sat, 2 Dec 2006 22:31:37 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-setting-resets-on-rooms-that-have-none-yet-will-crash-1280/&p=4795#p4795 Bug: Setting resets on rooms that have none yet will crash Danger: High - Crash condition. Discovered in: AFKMud 1.77 Found by: pstone Fixed by: Remcon --- [b]reset.c, do_reset[/b] in the "random" part find [code] if( ch->in_room->first_reset->prev ) ch->in_room->first_reset->prev = pReset; [/code] change it to [code] if( ch->in_room->first_reset ) ch->in_room->first_reset->prev = pReset; [/code] in the "trap" "obj" part find [code] https://smaugmuds.afkmods.com/topic/bug-setting-resets-on-rooms-that-have-none-yet-will-crash-1280/&p=4795#p4795 Sat, 2 Dec 2006 19:27:16 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-run-command-does-not-stop-the-player-if-combat-begins-1279/&p=4794#p4794 Bug: Run command does not stop the player if combat begins Danger: High - Game exploit condition. Could be used to circumvent required events. Discovered in: AFKMud 1.77 Found by: Zeno Fixed by: Samson --- [b]act_move.c, do_run[/b] Locate: [code] if( ( pexit = find_door( ch, arg, TRUE ) ) != NULL ) { if( ch->move < 1 ) { send_to_char( "You are too exhausted to run anymore.\n\r", ch ); ch->move = 0; https://smaugmuds.afkmods.com/topic/bug-run-command-does-not-stop-the-player-if-combat-begins-1279/&p=4794#p4794 Sat, 2 Dec 2006 19:14:18 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-exit-creation-stumbles-on-flags-in-the-argument-1278/&p=4792#p4792 Bug: Exit creation stumbles on flags in the argument Danger: Low - Ending up with partly broken exits makes more work for people to fix. Discovered in: AFKMud 1.77 Found by: pstone Fixed by: Samson --- [b]build.c, do_redit[/b] Locate: [code] if( !str_cmp( arg, "exit" ) ) { bool addexit, numnotdir; argument = one_argument( argument, arg2 ); argument = one_argument( argument, arg3 ); if( !arg2 || arg2[0] == '\0' ) { send_to_char( https://smaugmuds.afkmods.com/topic/bug-exit-creation-stumbles-on-flags-in-the-argument-1278/&p=4792#p4792 Sat, 2 Dec 2006 18:53:06 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-auction-item-is-not-checked-when-object-is-extracted-1266/&p=4691#p4691 Bug: Auction item is not checked when object is extracted Danger: Medium - Crash under select conditions. Discovered in: AFKMud 1.77 Found by: Remcon Fixed by: Samson --- [b]handler.c[/b] Locate: [code] #include <string.h> #include "mud.h" [/code] Below that, add: [code] #include "auction.h" [/code] [b]handler.c, extract_obj[/b] Locate: [code] if( obj->item_type == ITEM_PORTAL ) remove_portal( obj ); [/code] Below that, add: [code] if( auction->i https://smaugmuds.afkmods.com/topic/bug-auction-item-is-not-checked-when-object-is-extracted-1266/&p=4691#p4691 Sun, 12 Nov 2006 22:55:50 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-pfile-pruner-has-several-problems-1265/&p=4690#p4690 Bug: Pfile pruner has several problems Danger: Medium - Possible infinite loop on file read, bad string display for status messages Discovered in: AFKMud 1.77 Found by: Toadvile Fixed by: Toadvile/Samson --- [b]pfiles.c, fread_pfile[/b] Replace the function with this new one: [code] void fread_pfile( FILE * fp, time_t tdiff, char *fname, bool count ) { char *name = NULL; char *clan = NULL; char *deity = NULL; short level = 0; short file_ver = 0; EXT_BV pac https://smaugmuds.afkmods.com/topic/bug-pfile-pruner-has-several-problems-1265/&p=4690#p4690 Sun, 12 Nov 2006 12:29:47 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-switched-pcs-cause-crash-in-color-processing-1260/&p=4650#p4650 Bug: Switched PC's cause crash in color processing Danger: Low - Not an issue unless switched into an NPC. Discovered in: AFKMud 1.77 Found by: Samson Fixed by: Samson --- [b]color.c, colorcode[/b] Locate: [code] /* * Yes, this reset here is quite necessary to cancel out other things */ mudstrlcpy( dst, ANSI_RESET, dstlen ); if( ch ) mudstrlcat( dst, color_str( ch https://smaugmuds.afkmods.com/topic/bug-switched-pcs-cause-crash-in-color-processing-1260/&p=4650#p4650 Sun, 5 Nov 2006 16:41:20 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-previous-fix-for-deleted-rooms-is-itself-a-crash-vector-1259/&p=4639#p4639 Bug: Previous fix for deleted rooms is itself a crash vector Danger: High - Legitimately missing vnums will now cause a crash instead Discovered in: AFKMud 1.77 Found by: Kigen Fixed by: Kigen --- [b]handler.c, char_to_room[/b] Locate: [code] if( !get_room_index( pRoomIndex->vnum ) ) pRoomIndex = NULL; if( !pRoomIndex ) { bug( "Char_to_room: %s -> NULL room! Putting char in limbo (%d)", ch->name, ROOM_VNUM_LIMBO ); /* * This used to just https://smaugmuds.afkmods.com/topic/bug-previous-fix-for-deleted-rooms-is-itself-a-crash-vector-1259/&p=4639#p4639 Sun, 5 Nov 2006 14:39:35 CST AFKMud Bug Archive nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-switched-players-always-show-help-start-1256/&p=4635#p4635 Bug: Switched players always show [help start] Danger: Trivial - Minor display glitch Discovered in: AFKMud 1.77 Found by: Kazro Fixed by: Toadvile --- [b]comm.c, display_prompt[/b] Locate: [code] if( !IS_PCFLAG( ch, PCFLAG_HELPSTART ) ) prompt = helpstart; [/code] Change to: [code] if( !IS_NPC(ch) && !IS_PCFLAG( ch, PCFLAG_HELPSTART ) ) prompt = helpstart; [/code] This is a side affect of not paying attention to the logic of the IS_PCFLAG macro and f https://smaugmuds.afkmods.com/topic/bug-switched-players-always-show-help-start-1256/&p=4635#p4635 Sun, 5 Nov 2006 13:42:25 CST AFKMud Bug Archive nobody@example.com (Samson)