https://smaugmuds.afkmods.com/index.php?a=rssfeed&f=27 The largest Smaug community resource site. - Bugfixes for the SWR FUSS codebase will be posted here. These topics can only be edited or replied to by forum moderators. en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/bug-telnet-control-character-arrays-are-of-the-wrong-type-4470/&p=21021#p21021 Bug: Telnet control character arrays are of the wrong type. Danger: Low - May or may not be interfering with the use of the telnet IAC command. Found by: Bobo Fixed by: David/Samson --- [b]comm.c[/b] Locate: [code]const char echo_off_str[] = { ( char )IAC, ( char )WILL, TELOPT_ECHO, '\0' }; const char echo_on_str[] = { ( char )IAC, ( char )WONT, TELOPT_ECHO, '\0' }; const char go_ahead_str[] = { ( char )IAC, ( char )GA, '\0' };[/code] Replace with: [code]const unsigned char ec https://smaugmuds.afkmods.com/topic/bug-telnet-control-character-arrays-are-of-the-wrong-type-4470/&p=21021#p21021 Sat, 16 Oct 2010 17:02:16 CDT SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-auto-exits-dont-check-position-before-moving-character-4453/&p=20954#p20954 Bug: Auto-Exits don't check position before moving character. Danger: Medium - Players can move through auto-exits regardless of their position Found by: Banner Fixed by: Sharmair/Kayle --- Interp.c, interpret Find: [code] { EXIT_DATA *pexit; /* * check for an auto-matic exit command */ if( ( pexit = find_door( ch, command, TRUE ) ) != NULL && IS_SET( pexit->exit_info, EX_xAUTO ) ) { if( IS_SET( pexit- https://smaugmuds.afkmods.com/topic/bug-auto-exits-dont-check-position-before-moving-character-4453/&p=20954#p20954 Sat, 14 Aug 2010 12:38:07 CDT SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-mobprogs-fails-to-assign-to-mobsobjs-correctly-4399/&p=20601#p20601 Bug: MobProgs fail to assign to mobs/objs correctly Danger: Low - Progs just won't work. Found by: Dekar Fixed by: Remcon --- [b]db.c[/b] In [i]fread_fuss_mobprog[/i], Find: [code] SET_BIT( prog_target->progtypes, 1 << mprg->type ); [/code] Change to: [code] SET_BIT( prog_target->progtypes, mprg->type ); [/code] In [i]fread_fuss_objprog[/i], Find: [code] SET_BIT( prog_target->progtypes, 1 << mprg->type ); [/code] Change https://smaugmuds.afkmods.com/topic/bug-mobprogs-fails-to-assign-to-mobsobjs-correctly-4399/&p=20601#p20601 Wed, 21 Apr 2010 05:23:37 CDT SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-compressend-doesnt-handle-itself-very-well-4398/&p=20600#p20600 Bug: compressEnd doesn't handle itself very well. Danger: Medium - Could contribute to rare issue of compressed streams becoming corrupted. Found by: Nick Gammon Fixed by: Nick Gammon --- [b]mccp.c[/b] Replace the compressEnd function with: [code]bool compressEnd( DESCRIPTOR_DATA * d ) { unsigned char dummy[1]; if( !d->mccp->out_compress ) return TRUE; d->mccp->out_compress->avail_in = 0; d->mccp->out_compress->next_in = dummy; if( deflate( d->mc https://smaugmuds.afkmods.com/topic/bug-compressend-doesnt-handle-itself-very-well-4398/&p=20600#p20600 Wed, 21 Apr 2010 05:20:26 CDT SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-memory-leak-in-freedesc-4341/&p=20233#p20233 Bug: Memory Leak in free_desc Danger: High - Memory Leaks are BAD. Found by: Nick Gammon Fixed by: Nick Gammon --- comm.c, free_desc Change to: [code]void free_desc( DESCRIPTOR_DATA * d ) { compressEnd( d ); close( d->descriptor ); STRFREE( d->host ); DISPOSE( d->outbuf ); if( d->pagebuf ) DISPOSE( d->pagebuf ); DISPOSE( d->mccp ); DISPOSE( d ); return; }[/code] This is definitely a Doh! kinda thing. Don't know how long this has gone with https://smaugmuds.afkmods.com/topic/bug-memory-leak-in-freedesc-4341/&p=20233#p20233 Mon, 22 Feb 2010 23:30:46 CST SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/enh-easier-to-understand-messages-for-get-all-4337/&p=20229#p20229 This nifty enhancement changes the messages when there's nothing in the container you attempt to "get all" from to something that makes a little more sense, and tells you what you tried to get thing from. Found by: Nick Gammon [i]act_obj.c, do_get[/i] Find: [code] if( !obj ) { act( AT_PLAIN, IS_OBJ_STAT( container, ITEM_COVERING ) ? "I see nothing like that beneath the $T." : "I see nothing like that in the $T.", ch, NULL, arg1, TO_CHAR ); https://smaugmuds.afkmods.com/topic/enh-easier-to-understand-messages-for-get-all-4337/&p=20229#p20229 Mon, 22 Feb 2010 23:26:59 CST SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-isvalidvnum-fails-to-check-through-build-areas-4311/&p=20021#p20021 Bug: is_valid_vnum fails to check through build areas Danger: Major - Builder's will be unable to enter their areas. Found by: Kayle Fixed by: Kayle --- [b]build.c[/b], is_valid_vnum Replace the whole function with: [code]/* Is valid vnum checks to make sure an area has the valid vnum for any type types: 0=room, 1=obj, 2=mob -->Keberus 12/03/08 */ bool is_valid_vnum( int vnum, short type ) { AREA_DATA *area; int low_value =-1, hi_value =-1; bool https://smaugmuds.afkmods.com/topic/bug-isvalidvnum-fails-to-check-through-build-areas-4311/&p=20021#p20021 Sat, 6 Feb 2010 15:05:39 CST SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-immortals-cannot-always-detect-trapped-items-4309/&p=20004#p20004 Bug: Immortals cannot always detect trapped items Danger: Trivial - Item information display is missing a holylight check. Found by: Smaug 1.8 Fixed by: Smaug 1.8 --- [b]act_info.c, format_obj_to_char[/b] Locate: [code] if( IS_AFFECTED( ch, AFF_DETECTTRAPS ) && is_trapped( obj ) ) mudstrlcat( buf, "(Trap) ", MAX_STRING_LENGTH );[/code] Change to: [code] if( ( IS_AFFECTED( ch, AFF_DETECTTRAPS ) || IS_SET( ch->act, PLR_HOLYLIGHT ) ) && is_trapped( obj ) ) mudstrl https://smaugmuds.afkmods.com/topic/bug-immortals-cannot-always-detect-trapped-items-4309/&p=20004#p20004 Fri, 5 Feb 2010 00:04:17 CST SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-topsn-value-is-altered-by-loadcommands-and-loadsocials-4308/&p=20003#p20003 Bug: top_sn value is altered by load_commands and load_socials Danger: Low - Will only present a problem if these functions are ever moved past load_skill_table Found by: Remcon Fixed by: Remcon --- [b]tables.c, load_commands ( and load_socials )[/b] Locate and remove: [code]top_sn = 0;[/code] This is a relatively minor thing since the current order of loading pulls in the commands and socials long before the skills. But should the load order ever get redone, this would have made https://smaugmuds.afkmods.com/topic/bug-topsn-value-is-altered-by-loadcommands-and-loadsocials-4308/&p=20003#p20003 Fri, 5 Feb 2010 00:04:13 CST SWR FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-memory-leak-in-freadobj-4307/&p=20002#p20002 Bug: Memory leak in fread_obj Danger: Medium - Leak only occurs on incomplete objects Found by: Remcon Fixed by: Remcon/Samson --- [b]save.c, fread_obj[/b] Locate: [code] if( !fNest || !fVnum ) { if( obj->name ) bug( "Fread_obj: %s incomplete object.", obj->name ); else bug( "%s", "Fread_obj: incomplete object." ); if( obj->name ) STR https://smaugmuds.afkmods.com/topic/bug-memory-leak-in-freadobj-4307/&p=20002#p20002 Fri, 5 Feb 2010 00:04:09 CST SWR FUSS Bugfix List nobody@example.com (InfiniteAxis)