https://smaugmuds.afkmods.com/index.php?a=rssfeed&f=28 The largest Smaug community resource site. - Bugfixes for the SWFOTE FUSS codebase will be posted here. These topics can only be edited or replied to by forum moderators. en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/bug-telnet-control-character-arrays-are-of-the-wrong-type-4469/&p=21020#p21020 Bug: Telnet control character arrays are of the wrong type. Danger: Low - May or may not be interfering with the use of the telnet IAC command. Found by: Bobo Fixed by: David/Samson --- [b]comm.c[/b] Locate: [code]const char echo_off_str[] = { ( char )IAC, ( char )WILL, TELOPT_ECHO, '\0' }; const char echo_on_str[] = { ( char )IAC, ( char )WONT, TELOPT_ECHO, '\0' }; const char go_ahead_str[] = { ( char )IAC, ( char )GA, '\0' };[/code] Replace with: [code]const unsigned char ec https://smaugmuds.afkmods.com/topic/bug-telnet-control-character-arrays-are-of-the-wrong-type-4469/&p=21020#p21020 Sat, 16 Oct 2010 17:02:05 CDT SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-auto-exits-dont-check-position-before-moving-character-4455/&p=20956#p20956 Bug: Auto-Exits don't check position before moving character. Danger: Medium - Players can move through auto-exits regardless of their position Found by: Banner Fixed by: Sharmair/Kayle --- Interp.c, interpret Find: [code] { EXIT_DATA *pexit; /* * check for an auto-matic exit command */ if( ( pexit = find_door( ch, command, TRUE ) ) != NULL && IS_SET( pexit->exit_info, EX_xAUTO ) ) { if( IS_SET( pexit- https://smaugmuds.afkmods.com/topic/bug-auto-exits-dont-check-position-before-moving-character-4455/&p=20956#p20956 Sat, 14 Aug 2010 12:38:25 CDT SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-space-combat-skills-use-wrong-modifier-4454/&p=20955#p20955 Bug: Space Combat skills use wrong modifier Danger: Low - Damage is higher without skill then with skill. Found by: Ayuri Fixed by: Keberus --- Space.c, damage_ship_ch Find: [code] if( ch->pcdata->learned[gsn_spacecombat] > 1 && ch->pcdata->learned[gsn_spacecombat2] < 1 && ch->pcdata->learned[gsn_spacecombat3] < 1 ) ship->hull -= sdamage * 4; else if( ch->pcdata->learned[gsn_spacecombat] > 1 && ch->pcdata->learned[gsn_spacecombat2] > 1 && ch https://smaugmuds.afkmods.com/topic/bug-space-combat-skills-use-wrong-modifier-4454/&p=20955#p20955 Sat, 14 Aug 2010 12:38:22 CDT SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-helpfiles-will-loop-endlessly-if-a-number-is-input-4403/&p=20631#p20631 Bug: Helpfiles will loop endlessly if a number is input Danger: High - Crash Likely - Numbers are mishandled and lead to an infinite loop. Found by: MagisterXero Fixed by: Kayle --- [b]act_info.c[/b] In [i]get_help[/i], Find: [code] if( isdigit( argument[0] ) ) { lev = number_argument( argument, argnew ); argument = argnew; }[/code] Replace with: [code] if( isdigit( argument[0] ) && !is_number( argument ) ) { lev = number_argument( argument, ar https://smaugmuds.afkmods.com/topic/bug-helpfiles-will-loop-endlessly-if-a-number-is-input-4403/&p=20631#p20631 Thu, 22 Apr 2010 09:16:16 CDT SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-mobprogs-fails-to-assign-to-mobsobjs-correctly-4400/&p=20602#p20602 Bug: MobProgs fail to assign to mobs/objs correctly Danger: Low - Progs just won't work. Found by: Dekar Fixed by: Remcon --- [b]db.c[/b] In [i]fread_fuss_mobprog[/i], Find: [code] SET_BIT( prog_target->progtypes, 1 << mprg->type ); [/code] Change to: [code] SET_BIT( prog_target->progtypes, mprg->type ); [/code] In [i]fread_fuss_objprog[/i], Find: [code] SET_BIT( prog_target->progtypes, 1 << mprg->type ); [/code] Change https://smaugmuds.afkmods.com/topic/bug-mobprogs-fails-to-assign-to-mobsobjs-correctly-4400/&p=20602#p20602 Wed, 21 Apr 2010 05:23:49 CDT SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-compressend-doesnt-handle-itself-very-well-4397/&p=20599#p20599 Bug: compressEnd doesn't handle itself very well. Danger: Medium - Could contribute to rare issue of compressed streams becoming corrupted. Found by: Nick Gammon Fixed by: Nick Gammon --- [b]mccp.c[/b] Replace the compressEnd function with: [code]bool compressEnd( DESCRIPTOR_DATA * d ) { unsigned char dummy[1]; if( !d->mccp->out_compress ) return TRUE; d->mccp->out_compress->avail_in = 0; d->mccp->out_compress->next_in = dummy; if( deflate( d->mc https://smaugmuds.afkmods.com/topic/bug-compressend-doesnt-handle-itself-very-well-4397/&p=20599#p20599 Wed, 21 Apr 2010 05:20:14 CDT SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-memory-leak-in-freedesc-4342/&p=20234#p20234 Bug: Memory Leak in free_desc Danger: High - Memory Leaks are BAD. Found by: Nick Gammon Fixed by: Nick Gammon --- comm.c, free_desc Change to: [code]void free_desc( DESCRIPTOR_DATA * d ) { compressEnd( d ); close( d->descriptor ); STRFREE( d->host ); DISPOSE( d->outbuf ); if( d->pagebuf ) DISPOSE( d->pagebuf ); DISPOSE( d->mccp ); DISPOSE( d ); return; }[/code] This is definitely a Doh! kinda thing. Don't know how long this has gone with https://smaugmuds.afkmods.com/topic/bug-memory-leak-in-freedesc-4342/&p=20234#p20234 Mon, 22 Feb 2010 23:31:18 CST SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/enh-easier-to-understand-messages-for-get-all-4338/&p=20230#p20230 This nifty enhancement changes the messages when there's nothing in the container you attempt to "get all" from to something that makes a little more sense, and tells you what you tried to get thing from. Found by: Nick Gammon [i]act_obj.c, do_get[/i] Find: [code] if( !obj ) { act( AT_PLAIN, IS_OBJ_STAT( container, ITEM_COVERING ) ? "I see nothing like that beneath the $T." : "I see nothing like that in the $T.", ch, NULL, arg1, TO_CHAR ); https://smaugmuds.afkmods.com/topic/enh-easier-to-understand-messages-for-get-all-4338/&p=20230#p20230 Mon, 22 Feb 2010 23:27:14 CST SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-isvalidvnum-fails-to-check-through-build-areas-4310/&p=20020#p20020 Bug: is_valid_vnum fails to check through build areas Danger: Major - Builder's will be unable to enter their areas. Found by: Kayle Fixed by: Kayle --- [b]build.c[/b], is_valid_vnum Replace the whole function with: [code]/* Is valid vnum checks to make sure an area has the valid vnum for any type types: 0=room, 1=obj, 2=mob -->Keberus 12/03/08 */ bool is_valid_vnum( int vnum, short type ) { AREA_DATA *area; int low_value =-1, hi_value =-1; bool https://smaugmuds.afkmods.com/topic/bug-isvalidvnum-fails-to-check-through-build-areas-4310/&p=20020#p20020 Sat, 6 Feb 2010 15:05:36 CST SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/bug-skill-affects-get-loaded-backward-onto-skill-entries-4293/&p=19984#p19984 Bug: Skill affects get loaded backward onto skill entries Danger: Low - Normally not an issue. Can be a problem if relying on the affect order. Found by: Valcados Fixed by: Samson --- [b]mud.h[/b] Locate: [code] /* * A SMAUG spell */ struct smaug_affect { SMAUG_AFF *next; char *duration; short location; char *modifier; int bitvector; /* this is the bit number */ }; [/code] Change to: [code] /* * A SMAUG spell */ struct smaug_affect { SMAUG https://smaugmuds.afkmods.com/topic/bug-skill-affects-get-loaded-backward-onto-skill-entries-4293/&p=19984#p19984 Thu, 4 Feb 2010 17:15:27 CST SWFOTE FUSS Bugfix List nobody@example.com (InfiniteAxis)