https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=182 The largest Smaug community resource site. - Last of the 1.5 series en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=672#p672 After slogging through a few iterations of make/grind/fix leak/repeat, I've hit an impasse that is preventing me from reaching the next batch: ==14129== 30161 bytes in 803 blocks are still reachable in loss record 4 of 5 ==14129== at 0x4002989A: calloc (vg_replace_malloc.c:273) ==14129== by 0x80FA594: str_alloc (hashstr.c:52) ==14129== by 0x80D7FF6: fread_string (db.c:618) ==14129== by 0x815B57B: load_class_file (tables.c:170) Relevant section of load_class_file: case 'N': K https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=672#p672 Fri, 10 Oct 2003 22:08:46 CDT AFKMud Release Announcements nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=680#p680 *Feindish laugh from the 8th level of hell* DEATH TO LEAKS! *Ahem* There. That felt better. It seems I've managed a solution. Copied fread_string and named the copy fread_flagstring. Behaved identically, except only returns a static buffer instead of allocating the result each time. Appears at first look to have fit the bill nicely. Now to hunt down the remaining little bastards who hide from me in the night and make fun of me..... https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=680#p680 Fri, 10 Oct 2003 21:30:43 CDT AFKMud Release Announcements nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=679#p679 Point taken about the ego thing. Don't know why it was capped that way. 90K it is. As for tables.c, changed to fread_string_nohash/DISPOSE Got the following: Fri Oct 10, 2003 4:31:18 PM PDT :: Loading commands... ==10517== Invalid free() / delete / delete[] ==10517== at 0x400296D7: free (vg_replace_malloc.c:220) ==10517== by 0x815E21B: fread_command (tables.c:1599) ==10517== by 0x815E3EB: load_commands (tables.c:1702) ==10517== by 0x80DACE9: boot_db (db.c:2081) ==10517== Addres https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=679#p679 Fri, 10 Oct 2003 18:37:38 CDT AFKMud Release Announcements nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=671#p671 I know obj_ego gets initialized to whatever obj->rent has, but what I'm puzzled by is why it gets clipped to 90 if it's over 100K, but from 91K to 99K can be 91 through 99. In other words, why not clip it at 100, or why not do the clipping for > 90K? IOW: Why should a weapon worth 95K have a 95 ego, but a weapon worth 500K has only a 90 ego? Hmmm, as to the memory leak... I'm assuming something else has a lock on those shared string buffers. SInce many of the commands are common words, the https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=671#p671 Fri, 10 Oct 2003 08:07:29 CDT AFKMud Release Announcements nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=678#p678 The fight.c thing is moot. do_murder was taken out and it's PK checks consolidated into do_kill. The object ego calc is correct, look further up. The variable obj_ego is set to obj->rent before getting to where you're looking. The memory leak in tables.c: ==22811== 61112 bytes in 1923 blocks are still reachable in loss record 5 of 6 ==22811== at 0x4002989A: calloc (vg_replace_malloc.c:273) ==22811== by 0x80FA4E0: str_alloc (hashstr.c:52) ==22811== by 0x80D7EEF: fread_string (db.c:545 https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=678#p678 Thu, 9 Oct 2003 14:30:14 CDT AFKMud Release Announcements nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=677#p677 Here's a possible bug in the item_ego() routine of act_obj.c: [code] if( obj_ego >= 100000 ) obj_ego = 90; else obj_ego /= 1000; return(obj_ego);[/code] The code above seems to want to cap the return value at 90, but if obj_ego is between 91000 and 99999, it will return 91..99 as a value. Is that intended? It seems like you'd either want it to retu https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=677#p677 Thu, 9 Oct 2003 14:01:40 CDT AFKMud Release Announcements nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=670#p670 and... one more little memory leak bug... in tables.c, there's an fread_string to a temp variable around line 1603, it needs to have a companion STRFREE before it goes out of scope: [code] case 'F': if( !str_cmp( word, "flags" ) ) { if( version flags = fread_number( fp ); fMatch = TRUE; break; } else { char *cmdflags = NULL; cha https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=670#p670 Fri, 3 Oct 2003 14:06:18 CDT AFKMud Release Announcements nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=676#p676 I think I found one more little bug in fight.c [code] WAIT_STATE( ch, 1 * sysdata.pulseviolence ); sprintf( buf, "Help! I am being attacked by %s!", IS_NPC( ch ) ? ch->short_descr : ch->name ); if ( !IS_PKILL(victim) ) interpret( victim, buf ); [/code] around line 4036, in do_murder, I believe that wants to be something more like "shout Help! I am....". The murder verb may not be used very often, so this might not have really shown up. https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=676#p676 Wed, 1 Oct 2003 13:58:29 CDT AFKMud Release Announcements nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=669#p669 strlcpy/strlcat return the number of characters that you wanted to copy, which allows for overflow detection by checking if retlen > len (in case that matters, perhaps in data storage or OLC routines). If you want to use the more common strncpy/strncat routines without looping through the source string once (as the strl family does), you can do so, but it will have slightly (function call) more overhead. To also detect overflows, you'd have to call strlen, which would be not quite double the https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=669#p669 Wed, 24 Sep 2003 20:47:34 CDT AFKMud Release Announcements nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=675#p675 Yes, just checked with a FreeBSD server I have access to. strlcpy and strlcat are both there. They are not present in Cygwin or Linux though. My understanding of the licensing involved is that BSD code is compatible with Diku licensing. While you may be able to charge for BSD licensed products, you are also allowed to use portions of them in product which payment is forbidden for. So I may just go ahead and run the audit on those. Already hacked away at WAY too much to use the patch. No do https://smaugmuds.afkmods.com/topic/afkmud-156b-released-182/&p=675#p675 Wed, 24 Sep 2003 16:22:35 CDT AFKMud Release Announcements nobody@example.com (Samson)