https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=2378 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=9044#p9044 This seems to be related to virtual rooms ([url=http://smaugmuds.afkmods.com/index.php?a=topic&t=2434&p=9043#9043]see here[/url]). It seems get_room_index() doesn't check the virtual room hash table (vroom_hash[]). That is why the mobiles in the coruscant_streets area file are affected, as that's where virtual rooms are used in the SWR distro. Since this glitch haven't been spotted earlier I think we can safely assume very few ever used virtual rooms. I'd love to post the fix, but I'm not ver https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=9044#p9044 Thu, 4 Jan 2007 05:12:56 CST SWR FUSS nobody@example.com (Caius) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8801#p8801 Removing vnums from the game would probably do that if you removed any of the ones required by hardcoded references. That's outside the scope of the fix. Can't code against reckless deletion :) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8801#p8801 Sat, 18 Nov 2006 18:58:55 CST SWR FUSS nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8797#p8797 Naw, I'm starting to think it has something to do with the new check (vnum) that you added. Though I'm not sure how SWR handles its rooms so I'm no expert. Because I noticed that when I started the mud up I got those errors, but the mud didn't crash, meaning there was a valid pointer, it just didn't have the proper "vnum." https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8797#p8797 Sat, 18 Nov 2006 10:47:17 CST SWR FUSS nobody@example.com (Kigen) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8772#p8772 check your resets and make sure there are no nasty errors. (aassign area, reset list) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8772#p8772 Mon, 13 Nov 2006 17:05:02 CST SWR FUSS nobody@example.com (kiasyn) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8771#p8771 I'm having the same problem BUT I am planing on keeping the areas. I've done nothing to the code or areas. Simply compiled, started the mud and logged in and I get spammed with tons of: Log: [*****] BUG: char_to_room: businessman man human -> NULL room! Putting char in limbo (2) Messages. Different mobs, but 20 or so at a time. When I check limbo it seems like darn near every mob is in there. -Moridian https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8771#p8771 Mon, 13 Nov 2006 05:46:51 CST SWR FUSS nobody@example.com (Moridian) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8710#p8710 Well, I was starting to wonder because I saw nothing that would block that statement. My knowledge in C/C++ comes from my seemingly unnatural logic and comprehension skills. I figured that its much more logical to do that if statement since you just use NULLing the pRoomIndex data to get the same affect, only thing is that you MUST check to see if the variable passed is not NULL before checking for a structure member, becuase you didn't check if the structure was NULL before checking if the https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8710#p8710 Sat, 4 Nov 2006 14:12:16 CST SWR FUSS nobody@example.com (Kigen) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8709#p8709 Oh, right. It's late. Your logic does indeed work. For some reason I must have been thinking you were doing a && instead of ||. Guess I should think about getting some sleep :P https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8709#p8709 Fri, 3 Nov 2006 23:56:47 CST SWR FUSS nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8708#p8708 I just tested my fix on SMAUG FUSS, it works perfectly fine. I was transported to Limbo, and the mud didn't crash. if( !pRoomIndex || !get_room_index( pRoomIndex->vnum ) ) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8708#p8708 Fri, 3 Nov 2006 23:48:24 CST SWR FUSS nobody@example.com (Kigen) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8707#p8707 Doesn't the OR statement fix the problem, it does the same freaking check. It might be true that it doesn't have a NULL pointer, but it does the vnum check afterward. https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8707#p8707 Fri, 3 Nov 2006 23:42:27 CST SWR FUSS nobody@example.com (Kigen) https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8706#p8706 Yes. It was the product of a recent hackish fix to prevent problems with edge cases caused by using rdelete on a room you're standing in. http://smaugmuds.afkmods.com/index.php?a=topic&t=2307 Your fix to it is actually not going to solve the problem we're trying to solve because the pRoomIndex pointer is still "valid" under the conditions that cause the crash we were trying to fix. Since your fix checks first for pRoomIndex being NULL, and the pointer isn't null, the vnum check is never goin https://smaugmuds.afkmods.com/topic/chartoroom-does-not-handle-null-room-correctly-2378/&p=8706#p8706 Fri, 3 Nov 2006 23:39:42 CST SWR FUSS nobody@example.com (Samson)