https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=3713 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15890#p15890 [code] lint main.c if [ "$?" -ne 0 ]; then echo "Blaspheme! Thy code is not PERFECT in the eyes of lint!" rm -f main.c fi [/code] *grin* https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15890#p15890 Wed, 17 Sep 2008 07:00:44 CDT General Discussions nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15889#p15889 Oh, my bad. I thought we were still rating about how warnings as errors are the devil. https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15889#p15889 Tue, 16 Sep 2008 14:12:35 CDT General Discussions nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15888#p15888 I think people were talking about how they do their own development. The flag is only relevant in FUSS when we run into one of the issues like we did for this time around. :wink: https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15888#p15888 Tue, 16 Sep 2008 13:56:41 CDT General Discussions nobody@example.com (David Haley) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15887#p15887 I really don't get why this discussion about the -Werror flag is still going on.. the packages are shipping with the -Werror flag enabled.. If you don't want it on.. delete it from the makefile when you download it.. https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15887#p15887 Tue, 16 Sep 2008 13:46:15 CDT General Discussions nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15886#p15886 I [i][b]eventually[/b][/i] fix all warnings, where eventually is in the not-too-distant future. I know which warnings are actually important and which I can get away with putting off for a while. Sometimes I think it's more important to just press ahead, in which case I really don't want warnings treated as errors. I never use the flag because I would have to keep turning it on and off; that would get on my nerves pretty quickly. Basically I am my own -Werror flag -- I allow minor warnings in th https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15886#p15886 Tue, 16 Sep 2008 11:13:07 CDT General Discussions nobody@example.com (David Haley) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15885#p15885 True, although part of the reason I treat all warnings as errors is that it forces me to go fix them. On the occasion I find one I don't want/need to fix right away (the sigsetmask one, for example), I'll remove the -Werror flag to get a build done, but I put it back so I don't just forget about it. When I tried recompiling with the newer gcc (4.1.2), I got about 35 new warnings, and so it wasn't hard to spot that error. Other codebases I've looked at have had, literally, hundreds of warn https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15885#p15885 Tue, 16 Sep 2008 06:25:18 CDT General Discussions nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15884#p15884 I don't think anyone here was suggesting to turn off warnings. Personally I was talking about not handling warnings as errors. https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15884#p15884 Mon, 15 Sep 2008 13:27:24 CDT General Discussions nobody@example.com (Zeno) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15883#p15883 Just as an amusing "proof" of why turning off warnings is a bad idea..... Here's a bug I JUST fixed from my old mud, which has been there since 1995. WileyMUD was written before Smaug existed, and so all the spell code is usually cut and pasted from one spell to another (no generic spell_smaug yet). Well, there are both spell_blah() routines to do the actual spell, and cast_blah() routines as the API to cast the spell. When you call cast_, it checks to see how the spell is being invoked, a https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15883#p15883 Sun, 14 Sep 2008 09:58:03 CDT General Discussions nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15860#p15860 Oh, I didn't mean a single flag would FIX the problem. Rather, it would allow people to compile things and ignore the various warnings AT THEIR OWN RISK. Personally, I'd rather have things error and fail at compile time, than risk crashes at run time. However, if all you're doing is downloading the MUD to see if you like it, getting it to work is probably more important than making sure it's 100% stable. That's why I'd put things like that in comments. If you understand the risk, and you' https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15860#p15860 Mon, 1 Sep 2008 21:51:26 CDT General Discussions nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15846#p15846 There are some minor things that are as easy as putting in a toggle flag in the Makefile. That's how the Cygwin support works for one. Toggle a flag, the code compiles extra stuff it wouldn't do otherwise. The problem comes when the difference between compilers creates a situation as completely insane as the const fix. That's not something you can correct with a simple flag. To fix that you really do need to go down into the dirty levels of the code and bring it up to speed the hard way. One https://smaugmuds.afkmods.com/topic/how-do-we-handle-the-errors-caused-by-gcc42-3713/&p=15846#p15846 Mon, 1 Sep 2008 19:20:38 CDT General Discussions nobody@example.com (Samson)