https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4447 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20937#p20937 It really isn't to bad and I long ago decided to just put everything in it instead of using both shared and non shared strings to make it easier to keep track of. https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20937#p20937 Mon, 9 Aug 2010 19:42:18 CDT SWR FUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20922#p20922 Shared strings introduce a (very small) amount of overhead during creation and freeing, and take up a (very small) amount of extra memory. Additionally, shared strings are, well, shared, so you can't just modify it as you please: you need to create a temporary copy, modify it, and then put it back into the shared string system. So you would not use a shared string if: - you were very concerned about every last byte of memory and processor instruction (the chances of this being true are next https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20922#p20922 Sun, 8 Aug 2010 23:10:38 CDT SWR FUSS nobody@example.com (David Haley) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20919#p20919 [quote=David Haley][quote]What's the difference between str_dup/dispose and the STRFREE/ALLOC anyway? [/quote] <br /> STRFREE and STRALLOC use a shared string mechanism (using reference counting) whereas str_dup and dispose don't. So, dispose will delete memory immediately even if other strings are using it; strfree on a non-shared pointer will look for reference count data that doesn't exist.[/quote]What's an example of a situation where str_dup would be favored over STRALLOC? https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20919#p20919 Sun, 8 Aug 2010 08:00:20 CDT SWR FUSS nobody@example.com (Banner) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20918#p20918 [quote]What's the difference between str_dup/dispose and the STRFREE/ALLOC anyway? [/quote] STRFREE and STRALLOC use a shared string mechanism (using reference counting) whereas str_dup and dispose don't. So, dispose will delete memory immediately even if other strings are using it; strfree on a non-shared pointer will look for reference count data that doesn't exist. https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20918#p20918 Sun, 8 Aug 2010 01:00:32 CDT SWR FUSS nobody@example.com (David Haley) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20917#p20917 [quote=Kayle]You need to double check that the clan names aren't being assigned using str_dup anywhere. They all need to use the same. if you want to use STRALLOC/STRFREE on the clan_name fields, then ALL changes to clan_name need to use STRALLOC/STRFREE, not just the accounts part of things.[/quote] Everywhere I access the player->clan variable I use STRFREE/ALLOC. Does that mean this is bad (can I not smash an str_dupped variable into a STRALLOC'd variable)? [code] ch->pcdata->clan->name https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20917#p20917 Sat, 7 Aug 2010 13:32:45 CDT SWR FUSS nobody@example.com (Banner) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20914#p20914 [quote] [code] if( ch->pcdata->clan ) { if( player->clan ) STRFREE( player->clan ); player->clan = STRALLOC( ch->pcdata->clan->name ); } else { if( player->clan ) STRFREE( player->clan ); // LINE 178 player->clan = STRALLOC( "" ); } [/code] [/quote] Instead of doing it like that I would do it like this [code] player->clan = N https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20914#p20914 Sat, 7 Aug 2010 11:38:32 CDT SWR FUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20912#p20912 You need to double check that the clan names aren't being assigned using str_dup anywhere. They all need to use the same. if you want to use STRALLOC/STRFREE on the clan_name fields, then ALL changes to clan_name need to use STRALLOC/STRFREE, not just the accounts part of things. https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20912#p20912 Sat, 7 Aug 2010 09:34:13 CDT SWR FUSS nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20909#p20909 https://smaugmuds.afkmods.com/topic/help-with-garbage-variables-4447/&p=20909#p20909 Fri, 6 Aug 2010 19:32:37 CDT SWR FUSS nobody@example.com (Banner)