https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4499 The largest Smaug community resource site. - Or how I learned to hate gcc en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21252#p21252 [quote=Sharmair]I have seen quite a number of places in MUD code that uses sprintf (or the like) when a strcpy would work better.[/quote] There's absolutely nothing wrong with using sprintf here, as long as it's invoked correctly (look at the second argument): [code] sprintf( victname, "%s", IS_NPC( victim ) ? victim->short_descr : race_table[victim->race].race_name ); [/code] This is exactly what the compiler's warning says: The call to sprintf lacked the literal string containing format a https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21252#p21252 Thu, 13 Jan 2011 03:09:41 CST SWFOTE FUSS nobody@example.com (Caius) https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21251#p21251 Thanks all for the help. Truly appreciate it. I'll poke about and try a few different things. And don't worry Aurin, I'm actually pretty clueless when it comes to programming. I just muddle my way though and yell when I get stuck :D There are a few more places where I'm seeing uninitialized values. I'll try to poke about and see what I can do now knowing what I'm looking for. Sharmair, As to the strcpy/format warnings - I'll also poke them with a stick and see what happens. And thanks for https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21251#p21251 Wed, 12 Jan 2011 15:50:15 CST SWFOTE FUSS nobody@example.com (ayuri) https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21250#p21250 definitely take Sharmair's advice over mine. *LOL* I'm more or less just starting, and trying to be helpful--when maybe I'm not. :P https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21250#p21250 Wed, 12 Jan 2011 07:50:31 CST SWFOTE FUSS nobody@example.com (Aurin) https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21249#p21249 As far as the first warning, like it was said before, the percent is never set to anything before it is used. Global, static and heap memory that is allocated with calloc will in fact be initialized to NULL (0), but something on the stack like this will not be set to anything at all. It will be whatever happens to be in that memory location when the function is entered, and that could be anything (thus the warning). In this case, as percent is only used in a math expression, and the res https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21249#p21249 Wed, 12 Jan 2011 07:33:43 CST SWFOTE FUSS nobody@example.com (Sharmair) https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21247#p21247 In order to fix the percent thing, do the following: Somewhere above the ifcheck with 'percent' in it, add the following: [code] percent = ch->pcdata->learned[gsn_bribe] [/code] I'm sure Kayle could give a better explanation other than the fact that you never gave 'percent' a value, which means the code uses NULL, which will crash the mud in this particular instance with the use of bribe, if it ever got past the compile sequence. heh https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21247#p21247 Tue, 11 Jan 2011 23:29:34 CST SWFOTE FUSS nobody@example.com (Aurin) https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21246#p21246 With no time to probe the track thing I don't have an answer for that one, but the bribe bit is actually a legitimate bug. Percent is never set to anything. It really is uninitialized. When I get some time tomorrow, I'll sit down here and try and give you a better explanation, and have a look at the track thing. https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21246#p21246 Tue, 11 Jan 2011 22:13:56 CST SWFOTE FUSS nobody@example.com (InfiniteAxis) https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21245#p21245 So, greetings everyone! Been a while. Updated my host, brand spanking new gcc 4.4.3! Now, as you all can imagine some new warnings are popping up after the old ones were cleared out. I thought I'd pick a few warnings and see what the community says. As far as I know, most of these functions should be fairly stock(?): swskills.c function do_bribe warning : "percent" may be used uninitialized in this function [code]void do_bribe ( CHAR_DATA *ch , char *argument ) { char arg1 [MAX_I https://smaugmuds.afkmods.com/topic/gcc-443-and-warnings-4499/&p=21245#p21245 Mon, 10 Jan 2011 20:58:45 CST SWFOTE FUSS nobody@example.com (ayuri)