https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4800 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23562#p23562 One less problem :P [code] case 'b': start = this->pageindex - ( pclines * 2 ); end = this->pageindex - ( pclines + 2 ); break;[/code] Strangely that seems to have fixed the B command. Not off to find my color bleeder.... ... and I found that too. The difference between if( ch->desc ) and if( !ch->desc ) is rather important :P https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23562#p23562 Fri, 5 Dec 2014 01:01:23 CST AFKMud Support & Development nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23561#p23561 I tried yours, but it never paused at the page breaks, although it seemed to be doing them in the right places. That said, I had also been working on this in the meantime and have this now: [codebox]bool descriptor_data::pager_output( ) { char_data *ch; int pclines; size_t start, end; bool ret; if( !this || this->pagebuf.empty( ) || this->pagecmd == -1 ) return true; ch = this->original ? this->original : this->character; pclines = umax( ch->pcdata-> https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23561#p23561 Thu, 4 Dec 2014 19:43:41 CST AFKMud Support & Development nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23560#p23560 Heh, yeah you're right on the UMAX thing... reading it backwards. Sorry. :) I'm just thinking in terms of what you want the pager to accomplish. Paged output gets queued up as lines of text, to be output to the user a "page" at a time, giving them the option to move up or down, abort the display early, or dump it all out at once. Therefore, all you really need to know is: What line is the current top-of-page for the user? What pager command did they issue last? How many lines fit https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23560#p23560 Thu, 4 Dec 2014 18:48:28 CST AFKMud Support & Development nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23559#p23559 So are you saying dump all this stuff where it figures out where start is and just have the switch statement do it itself? Also, changing to UMIN broke it. It was only spitting out 5 lines at a time. https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23559#p23559 Thu, 4 Dec 2014 16:35:46 CST AFKMud Support & Development nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23558#p23558 [code] pclines = UMAX( ch->pcdata->pagerlen, 5 ) - 1; [/code] Why? wouldn't you normally want to show pagerlen lines at a time? Maybe -1 for the prompt? I bet that really should be UMIN(), not UMAX(). [code] switch mess... [/code] I would probably make the default case just set start to be pageindex, and end to be pageindex + pclines, and then after displaying the set of lines in question, move pageindex to pageindex + pclines. That way the default paging action will display N l https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23558#p23558 Thu, 4 Dec 2014 12:00:20 CST AFKMud Support & Development nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23557#p23557 May help to post the function: [code]bool descriptor_data::pager_output( ) { char_data *ch; int pclines, start, end; register int lines; bool ret; if( !this || this->pagebuf.empty( ) || this->pagecmd == -1 ) return true; ch = this->original ? this->original : this->character; pclines = UMAX( ch->pcdata->pagerlen, 5 ) - 1; switch ( LOWER( this->pagecmd ) ) { default: lines = 0; break; case 'b': lines = https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23557#p23557 Thu, 4 Dec 2014 04:16:13 CST AFKMud Support & Development nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23556#p23556 Not sure about the way SmaugFUSS does pagers, but I can offer the way I changed WileyMUD's pager to be more sensible.... Instead of futzing around with string pointers from hell, in WileyMUD, i just changed the system so it keeps an array of lines. Whenever there's a line break in the pager output (usually via pager_printf), I NULL terminate the current line string and start a new one. Then, on paged output to the socket, I simply emit lines N to M, with CRLF appended to each, followed by https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23556#p23556 Thu, 4 Dec 2014 01:28:38 CST AFKMud Support & Development nobody@example.com (Quixadhal) https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23555#p23555 Working up to another update release, but I've got at least one set of problems I'd like to get worked out before that happens: https://github.com/Arthmoor/AFKMud/issues/11 The pager_output() code in descriptor.cpp has several issues: It bleeds color after the prompt. It repeats the last line it just showed you before resuming. The "N" prompt does not work. Using the "R" prompt refreshes but loses one line each time this is done. Using the "B" prompt goes back 1 les https://smaugmuds.afkmods.com/topic/pager-output-problems-4800/&p=23555#p23555 Wed, 3 Dec 2014 23:26:44 CST AFKMud Support & Development nobody@example.com (Samson)