https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4823 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/memory-leak-with-dohset-and-smashtildecopy-4823/&p=23635#p23635 This may be arbitrary as both solutions are "equal" (haven't tested them though). But as far as style or standards goes, which would you consider more conformant? [code]free(argument);[/code] or [code]argument = smash_tilde(argument);[/code] Assuming that this is a standard across all codebases: [code]const char * smash_tilde(const char *);[/code] I'm compiling on g++ and most of my char * argument's have been turned into const char *. https://smaugmuds.afkmods.com/topic/memory-leak-with-dohset-and-smashtildecopy-4823/&p=23635#p23635 Wed, 7 Sep 2016 18:29:10 CDT SWFOTE FUSS nobody@example.com (Kasji) https://smaugmuds.afkmods.com/topic/memory-leak-with-dohset-and-smashtildecopy-4823/&p=23631#p23631 great find, feel free to fix it and post a fix for everyone, if you would like to :) https://smaugmuds.afkmods.com/topic/memory-leak-with-dohset-and-smashtildecopy-4823/&p=23631#p23631 Mon, 5 Sep 2016 23:10:20 CDT SWFOTE FUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/memory-leak-with-dohset-and-smashtildecopy-4823/&p=23625#p23625 So, do_hset uses smash_tilde_copy. smash_tilde_copy uses strdup and returns a pointer to this duplicate string. do_hset doesn't free this string. Isn't this a memory leak? https://smaugmuds.afkmods.com/topic/memory-leak-with-dohset-and-smashtildecopy-4823/&p=23625#p23625 Mon, 5 Sep 2016 01:43:29 CDT SWFOTE FUSS nobody@example.com (Kasji)