https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4840 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23698#p23698 [quote=Samson]Looks like you got it right, but you forked from the main branch that only Kayle has access to rather than my fork, which is here: https://github.com/Arthmoor/SmaugFUSS That's fine though, because eventually it would need to move up to his branch anyway.[/quote] Sorry, I'm rather green about these things :p Sent a pull request to your fork, as well :) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23698#p23698 Sat, 28 Jan 2017 17:54:19 CST SmaugFUSS nobody@example.com (Sadiq) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23697#p23697 Looks like you got it right, but you forked from the main branch that only Kayle has access to rather than my fork, which is here: https://github.com/Arthmoor/SmaugFUSS That's fine though, because eventually it would need to move up to his branch anyway. https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23697#p23697 Sat, 28 Jan 2017 16:41:27 CST SmaugFUSS nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23696#p23696 [quote=Samson]Have you guys thought about making sure these get submitted to GitHub?[/quote] I made an account on GitHub (Username is Radamanthas - 'Sadiq' was taken :p ) and I *think* I got it worked out. I forked the repo into my account made the changes then sent a pull request. Someone please let me know if I did it all correctly, or if I need to do something else. Thanks! https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23696#p23696 Sat, 28 Jan 2017 09:04:17 CST SmaugFUSS nobody@example.com (Sadiq) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23688#p23688 [quote=Sadiq][quote=Samson]Have you guys thought about making sure these get submitted to GitHub?[/quote] I'm not adverse to the idea, but I have never used GitHub. I will have to go and figure out how to submit changes. :redface: [/quote] Likewise here, to be honest. Will have to check it out when I get a chance! https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23688#p23688 Fri, 20 Jan 2017 15:50:16 CST SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23687#p23687 [quote=Samson]Have you guys thought about making sure these get submitted to GitHub?[/quote] I'm not adverse to the idea, but I have never used GitHub. I will have to go and figure out how to submit changes. :redface: https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23687#p23687 Fri, 20 Jan 2017 07:34:16 CST SmaugFUSS nobody@example.com (Sadiq) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23686#p23686 Have you guys thought about making sure these get submitted to GitHub? https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23686#p23686 Wed, 18 Jan 2017 23:20:30 CST SmaugFUSS nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23683#p23683 And another good catch! You are on a roll! :tongue: https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23683#p23683 Wed, 18 Jan 2017 16:43:27 CST SmaugFUSS nobody@example.com (Sadiq) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23680#p23680 Okay, giving this another shot after the forum fix. Thanks Samson! :smile: In fight.c, violence_update( ), there is this bit regarding non-autonomous mobs potentially switching PC tanks: [code] /* * Group Fighting Styles Support: * If ch is tanking * If rch is using a more aggressive style than ch * Then rch is the new tank -h */ if( ( !IS_NPC(ch) && !IS_NPC(rch) ) &&( r https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23680#p23680 Sun, 15 Jan 2017 11:56:28 CST SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23677#p23677 I'm not seeing options for tagging anymore, and emoticons still don't work, so not really able to post the bug here. Think you might have some more kinks yet to work out. If I can edit later, I will try that. Otherwise will start a new topic. https://smaugmuds.afkmods.com/topic/bug-in-violenceupdate--4840/&p=23677#p23677 Sat, 14 Jan 2017 19:43:01 CST SmaugFUSS nobody@example.com (GatewaySysop)