https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4860 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23778#p23778 Yes and it was what u thought. I brought an old class back that had an old coded skill we haven't used in years. I foolishly assumed it was fine but eliminating all other possibilities looked at and found it making incomplete corpse objects which when fixed solved that. Thanks. https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23778#p23778 Tue, 13 Mar 2018 11:38:11 CDT SmaugFUSS nobody@example.com (Vladaar) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23762#p23762 [quote=Vladaar]Ok, thanks for clarifying. You might be right there, well seems only likely explanation.[/quote] Were you able to figure out if anything else was going on with this, or confirm what was causing the crash? https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23762#p23762 Tue, 13 Mar 2018 01:26:56 CDT SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23759#p23759 Ok, thanks for clarifying. You might be right there, well seems only likely explanation. https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23759#p23759 Fri, 9 Mar 2018 16:55:41 CST SmaugFUSS nobody@example.com (Vladaar) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23758#p23758 [quote=Vladaar]I'm not lying, I have no reason too. I'm not the best coder, and will not pretend to be. I posted cause I thought it was a legit bug or at least an issue with my code.[/quote] Nobody is saying you're lying. What I'm asking is why GDB's log is showing a different version of that block of code from what you posted initially. Notice the if ( ch ) check and redundant if( victim->hating ) checks. Where did those go? Your problem could well be that ch didn't exist when that con https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23758#p23758 Fri, 9 Mar 2018 15:27:32 CST SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23757#p23757 I'm not lying, I have no reason too. I'm not the best coder, and will not pretend to be. I posted cause I thought it was a legit bug or at least an issue with my code. https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23757#p23757 Fri, 9 Mar 2018 15:04:23 CST SmaugFUSS nobody@example.com (Vladaar) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23756#p23756 [quote=Vladaar]No. It's the same. [/quote] How can you make the assertion that the two above pieces of code are the same? Clearly they are not. I really want to help here and understand what's wrong, but I can't debug one piece of code when GDB was clearly looking at something else. https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23756#p23756 Fri, 9 Mar 2018 11:18:30 CST SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23755#p23755 No. It's the same. https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23755#p23755 Fri, 9 Mar 2018 06:14:06 CST SmaugFUSS nobody@example.com (Vladaar) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23754#p23754 A little perplexed. Why does this part from your GDB not match the code you posted earlier? [code] 2967 if(victim->hating) 2968 { 2969 if(victim->hating->who != ch) 2970 { 2971 if ( victim->hating ) 2972 STRFREE(victim->hating->name); 2973 if ( ch ) { 2974 victim->hating->name = QUICKLINK(ch->name); 2975 victim->hating->who = ch; 2976 } [/code] vs. [code] if( victim->hating ) { if( victim->hating->who != ch ) { STRFREE( victim- https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23754#p23754 Thu, 8 Mar 2018 23:55:45 CST SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23753#p23753 Should be copied and pasted from LOP when I ported it. It's almost exactly same as smaugfuss cept has more debugging info like file, line in bug messages whereas smaugfuss has some of it, but not quite as much. [code] #ifdef HASHSTR #define STRALLOC(point) str_alloc( (point), __FILE__, __LINE__ ) #define QUICKLINK(point) quick_link( (point), __FILE__, __LINE__ ) #define STRFREE(point) \ do \ { \ if( (point) ) \ { \ if( !in_hash_table( (point) ) ) \ { \ https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23753#p23753 Thu, 8 Mar 2018 20:39:04 CST SmaugFUSS nobody@example.com (Vladaar) https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23752#p23752 [quote=Vladaar]#define QUICKLINK(point) quick_link( (point), __FILE__, __LINE__ ) [/quote] I don't know about yours, but mine is conditional and I thought it was in stock. Maybe you should show what surrounds this? I seem to recall that if not using certain defines, it will fall back on using str_dup rather than hashing strings, won't it? Something like this: [code] #ifdef HASHSTR #define STRALLOC(point) str_alloc((point)) #define QUICKLINK(point) quick_link((point)) #define https://smaugmuds.afkmods.com/topic/strfree-on-strdup-fight-c-4860/&p=23752#p23752 Thu, 8 Mar 2018 20:22:22 CST SmaugFUSS nobody@example.com (GatewaySysop)