https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4904 The largest Smaug community resource site. - smaugfuss1.9 incomplete code en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23941#p23941 it would certainly be a better job. In my code I converted to extbv indeed. Strange that in many years the gap on the main code has never been noticed. https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23941#p23941 Sun, 3 May 2020 23:50:07 CDT Coding nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23940#p23940 Yes, and if that works for you, cool. I just don't see that kind of a workaround as an appropriate fix for it in the main codebase. For that I'd want to actually run it through as a proper conversion to EXT_BV. https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23940#p23940 Sun, 26 Apr 2020 12:56:10 CDT Coding nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23939#p23939 [quote=Samson]I'm pretty sure this also got updated to xBV in AFKMud before I then converted all of the BVs to std::bitset instead. It's not a task to be taken lightly either since there's a lot of places these things get used and you'll need to account for any pfiles or other data files that are storing data in the original format.[/quote] I agree with you. This is the reason why I proposed a simple workaround without convert to EXT_BV. Bye! https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23939#p23939 Sun, 26 Apr 2020 04:22:48 CDT Coding nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23938#p23938 Agreed, I remember it being quite a bit of work when I changed it all over lol. https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23938#p23938 Sat, 25 Apr 2020 21:33:08 CDT Coding nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23937#p23937 I'm pretty sure this also got updated to xBV in AFKMud before I then converted all of the BVs to std::bitset instead. It's not a task to be taken lightly either since there's a lot of places these things get used and you'll need to account for any pfiles or other data files that are storing data in the original format. https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23937#p23937 Sat, 25 Apr 2020 13:00:27 CDT Coding nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23936#p23936 Glad you figured out a way around it, Id changed the setup in LoP long ago and used the extended bits even though id split things up a lot more. This is one that does need addressed in Fuss though lol. https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23936#p23936 Fri, 24 Apr 2020 22:53:23 CDT Coding nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23935#p23935 ps: don't miss add case APPLY_EXT_AFFECT and relative code in: aris_affect showaffect affect_modify affect_loc_name tiny_affect_loc_name (in my codebase, I don't know about smaugfuss1.9 but much probably the same) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23935#p23935 Fri, 24 Apr 2020 08:16:26 CDT Coding nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23934#p23934 Oh yes, I simply noticed the problem. Missing other code about APPLY_EXT_AFFECT, for example an output related with ostat or identify. More than one solution in any case: I think that APPLY_EXT_AFFECT in the smaug intention was create an extended affect. The problem, like I said, is that in affect struct the ->modifier isnt a EXT_BV so in building area files you can't store text like 0&0&0&0 (null bitmask). If you store a bitvectory you need to chage in load_objects fread_number into frea https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23934#p23934 Fri, 24 Apr 2020 02:35:30 CDT Coding nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23933#p23933 Can you show what all you tried and the results you are getting? https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23933#p23933 Thu, 23 Apr 2020 21:36:39 CDT Coding nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23929#p23929 This is probably why I think most have redone this setup haha. https://smaugmuds.afkmods.com/topic/oset-obj-affect-affected-acidmist-4904/&p=23929#p23929 Thu, 23 Apr 2020 20:39:41 CDT Coding nobody@example.com (Remcon)