https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4912 The largest Smaug community resource site. - change return with continue en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23969#p23969 Nice catch, thank you for sharing the find and proposed fix! :cool: https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23969#p23969 Wed, 3 Feb 2021 23:19:44 CST SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23968#p23968 I had begun to suspect we had two different codes under our eyes. Once with a friend of mine we spent a day talking, realizing only at the end that my code was completely different from his. I also don't use the smaugfuss 1.9.4, but when I notice something I say it here hoping it will be useful to someone. Goodbye see you soon. https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23968#p23968 Tue, 2 Feb 2021 15:42:37 CST SmaugFUSS nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23967#p23967 My bad I was looking at mine and I had long ago changed it lol. So I went and looked in SmaugFUSS1.9.4 and I see it has this [code] if( !str_cmp( arg, "corpse" ) ) { char buf2[MAX_STRING_LENGTH]; OBJ_DATA *obj; bool found; bool retr = FALSE; if( ch->pcdata->favor < ch->pcdata->deity->scorpse ) { send_to_char( "You are not favored enough for a corpse retrieval.\r\n", ch ); return; } if( xIS_SET( ch->in_room-> https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23967#p23967 Tue, 2 Feb 2021 15:17:30 CST SmaugFUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23966#p23966 [quote=Remcon]Ok, so in this situation you want it to check every object looking for your corpses and bring you all it can. I think you are hinting at if it fails to bring one then [color=darkred]it shouldn't charge you the fee?[/color] It's meant more of if it brings you any you pay the fee. If I recall correctly.[/quote] No, quite the opposite. In my opinion, if one or more body is recovered, the PC should pay. currently under certain conditions this does not happen. I suggest somethin https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23966#p23966 Tue, 2 Feb 2021 02:56:24 CST SmaugFUSS nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23965#p23965 Ok, so in this situation you want it to check every object looking for your corpses and bring you all it can. I think you are hinting at if it fails to bring one then it shouldn't charge you the fee? It's meant more of if it brings you any you pay the fee. If I recall correctly. https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23965#p23965 Mon, 1 Feb 2021 15:50:42 CST SmaugFUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23964#p23964 [quote=Remcon]right, it is meant so that any corpse of yours that it can bring it will bring [color=yellow]all for the one set favor cost[/color]. It should continue on those places so it doesn't bring them but continue looking for other corpses. It uses the retr setting to know that it did find and bring you a corpse from somewhere.[/quote] I'm very sorry. My English is so terrible that I have great difficulty both expressing myself and understanding. Imagine this situation. I die 3 time https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23964#p23964 Sun, 31 Jan 2021 06:30:58 CST SmaugFUSS nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23963#p23963 right, it is meant so that any corpse of yours that it can bring it will bring all for the one set favor cost. It should continue on those places so it doesn't bring them but continue looking for other corpses. It uses the retr setting to know that it did find and bring you a corpse from somewhere. https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23963#p23963 Wed, 27 Jan 2021 17:57:30 CST SmaugFUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23962#p23962 Ok, probably I miss something but actually If you die two times (or more) and last corpse (or one in the middle) is in a nosupplicate room, when you supplicate corpse you don't pay favour*** and also It's possible you don't get any corpse or only the corpse obj that are listed before the corpse that stay in nosupplicate room. *** This because ch->pcdata->favor -= ch->pcdata->deity->scorpse; is located outside of loop. Correct? bye mat ps. Smaug 1.9.4 use "return" not "continue" https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23962#p23962 Wed, 27 Jan 2021 01:50:21 CST SmaugFUSS nobody@example.com (Matteo2303) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23961#p23961 the reason it is like that is it will bring every single corpse to you. if you do those returns it will how ever break out. you can use the word continue instead of return in each place and it have the desired result you are looking for. https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23961#p23961 Tue, 26 Jan 2021 19:14:38 CST SmaugFUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23960#p23960 Hello, In do_supplicate loop for "supplicate corpse" I suggest check "return" istance for two reasons: 1) If there are more than one corpse, and the last or one in the middle of list is in a ROOM_NOSUPPLICATE you don't pay favour costs. 2) if one corpse is in a ROOM_NOSUPPLICATE you can't get some other corpses that you are allowed to get. [code] for( obj = first_object; obj; obj = obj->next ) { if( obj->in_room && !str_cmp( buf2, obj->short_descr ) && ( obj->pInd https://smaugmuds.afkmods.com/topic/dosupplicate-4912/&p=23960#p23960 Mon, 25 Jan 2021 12:57:18 CST SmaugFUSS nobody@example.com (Matteo2303)