https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=4969 The largest Smaug community resource site. - Potential crash bug... en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24207#p24207 To be clear, it wasn't the fall that killed them and they didn't drown in a room from which falling was possible either. In this instance, ch was not an NPC, and this is where the trace pointed. Am guessing after get_exit( ) complained in the log about a null room, whoever tried to access pexit after this is what caused this particular issue. For context, was testing out a PC drowning after their mount drowned and left them in the drink. Mount died just fine, but when the PC drowned, that w https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24207#p24207 Sat, 31 Aug 2024 00:27:14 CDT SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24206#p24206 The problem is that will_fall() itself may not even be the issue. It could be one of the subsequent calls to other things it makes, the most obvious of which would be the extract_char() function. If ch happens to be an NPC, that could easily trigger a problem that's not easy to solve even with char_died() calls since char_died() requires a valid ch value. https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24206#p24206 Fri, 30 Aug 2024 22:53:01 CDT SmaugFUSS nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24205#p24205 In my case, I believe the issue was the character in question drowned. Subsequently, the char_check( ) call to will_fall( ) was trying to determine a down exit the the room ch was in, but of course that seg faulted since there wasn't any room and will_fall( ) was written assuming one would always exist for the caller, apparently. :shrug: My base is older and while patched up with every bug fix I ever found published, and then some, the trvch_wnext( ) thing is still on my to-do list. This ma https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24205#p24205 Fri, 30 Aug 2024 20:22:36 CDT SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24204#p24204 That portion of the function isn't the same as what's currently in the SmaugFUSS code: [code] lc1 = trworld_create( TR_CHAR_WORLD_FORW ); for( ch = first_char; ch; ch = trvch_wnext( lc1 ) ) { set_cur_char( ch ); will_fall( ch, 0 ); if( char_died( ch ) ) continue;[/code] Normally problems with this kind of loop stem from the fact that it isn't protecting against something being removed from a list during processing. I don't remember exactly where https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24204#p24204 Fri, 30 Aug 2024 13:27:51 CDT SmaugFUSS nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24203#p24203 Interesting thought. I did quite a bit of fall testing but hadn't been able to crash it. Can't hurt though! :imp: https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24203#p24203 Fri, 30 Aug 2024 12:57:22 CDT SmaugFUSS nobody@example.com (GatewaySysop) https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24202#p24202 You might want another check for char_died after will_fall as well since it could cause them to die. Haven't tested it or anything but it might be possible that would cause a crash as well or at least some undesired results. https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24202#p24202 Fri, 30 Aug 2024 04:59:27 CDT SmaugFUSS nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24200#p24200 Came across this by chance while tinkering with something new. Managed to produce a crash pretty readily and traced it back to here: In update.c, function char_check( ): [code] for ( ch = first_char; ch; ch = ch_next ) { set_cur_char(ch); ch_next = ch->next; [color=red]will_fall(ch, 0);[/color] if ( char_died( ch ) ) continue; [/code] That seems kinda... not smart. Change to this: [code] for ( ch = first_char; ch; ch = ch_next ) { set_cur_cha https://smaugmuds.afkmods.com/topic/bug-charcheck--4969/&p=24200#p24200 Fri, 30 Aug 2024 03:42:47 CDT SmaugFUSS nobody@example.com (GatewaySysop)