https://smaugmuds.afkmods.com/index.php?a=rssfeed&t=5002 The largest Smaug community resource site. - en SmaugMuds 60 https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24338#p24338 Ok, found the issue. fread_char was using the wrong string loader to load password hashes. Since I've been running my tests without doing full shutdowns I never ran into the leak report at exit. Hotboot had nothing to do with it, this would have been leaking password hashes in memory for pretty much everyone who logged on and then quit. 64 bytes at a time. It's not information anyone other than the MUD owner could see so it's not a security issue since they could just look right at someone https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24338#p24338 Sat, 11 Jan 2025 18:31:34 CST AFKMud Support & Development nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24337#p24337 Its possible just not freed on shutdown but if thats the case it is probably leaking all the time from characters. I didn't test it out to see. https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24337#p24337 Sat, 11 Jan 2025 14:32:40 CST AFKMud Support & Development nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24336#p24336 well it was just a loadup login messed around did a hotboot and later did a shutdown to see if it had any listed leaks and it showed that one. https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24336#p24336 Sat, 11 Jan 2025 14:31:46 CST AFKMud Support & Development nobody@example.com (Remcon) https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24335#p24335 I don't understand how that could be a memory leak. The same functions are used to load the player from a standard login and does exactly the same thing with their password. I only get weird stuff like that on bad boot ups when testing things. The sudden abort triggers the leak detection. Hotboot should not be doing that. https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24335#p24335 Sat, 11 Jan 2025 14:05:05 CST AFKMud Support & Development nobody@example.com (Samson) https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24334#p24334 [code] ==7934==ERROR: LeakSanitizer: detected memory leaks Direct leak of 65 byte(s) in 1 object(s) allocated from: #0 0x14c6a09fe6c8 in operator new[](unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:98 #1 0x555ecb0b19d7 in str_dup(char const*) /home/remcon/afkmud/src/editor.cpp:185 #2 0x555ecb0615da in fread_string_nohash(_IO_FILE*) /home/remcon/afkmud/src/db.cpp:713 #3 0x555ecb2b0180 in fread_char(char_data*, _IO_FILE*, bool, bool) /home/remcon/afkm https://smaugmuds.afkmods.com/topic/pwd-memory-leak-5002/&p=24334#p24334 Sat, 11 Jan 2025 09:38:53 CST AFKMud Support & Development nobody@example.com (Remcon)