Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing

Members: 0
Guests: 20
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] load_rooms doesn't prop...
Forum Rules | Mark all | Recent Posts

[Bug] load_rooms doesn't properly check sector types when loading rooms
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005 5:58 pm   Last edited May 11, 2005 8:40 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: The load_rooms function doesn't properly check sector types when loading a room.
Danger: High
Found by: Remcon
Fixed by: Remcon
-----
[db.c]

In load_rooms find:

        if (pRoomIndex->sector_type < 0 || pRoomIndex->sector_type == SECT_MAX)
        {
          bug( "Fread_rooms: vnum %d has bad sector_type %d.", vnum ,
              pRoomIndex->sector_type);
          pRoomIndex->sector_type = 1;
        }


Change it to:

        if (pRoomIndex->sector_type < 0 || pRoomIndex->sector_type >= SECT_MAX)
        {
          bug( "Fread_rooms: vnum %d has bad sector_type %d.", vnum ,
              pRoomIndex->sector_type);
          pRoomIndex->sector_type = 1;
        }


This can be bad because new areas may have sectors greater than SECT_MAX, and the code doesn't properly check for this.
       
Pages:<< prev 1 next >>