Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing, Google

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
tphegley (37)
Related Links
» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] The AFK flag check in i...
Forum Rules | Mark all | Recent Posts

[Bug] The AFK flag check in interp.c doesn't verify if the user is a player
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005 6:00 pm   Last edited May 11, 2005 8:44 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: The AFK flag check in interp.c doesn't verify if the user is a player.
Danger: low
Found by: gatewaysysop
Fixed by: Samson and gatewaysysop

[interp.c]

Find:

	/*
  * Turn off afk bit when any command performed.
  */
	if ( xIS_SET ( ch->act, PLR_AFK)  && (str_cmp(command, "AFK";)))
	{
     xREMOVE_BIT( ch->act, PLR_AFK );
/*
          act( AT_GREY, "$n is no longer afk.", ch, NULL, NULL, TO_ROOM );
*/
          act( AT_GREY, "$n is no longer afk.", ch, NULL, NULL, TO_CANSEE );
	}


Change it to:

	/*
  * Turn off afk bit when any command performed.
  */
	if ( !IS_NPC(ch) && xIS_SET ( ch->act, PLR_AFK)  && (str_cmp(command, "AFK";)))
	{
     xREMOVE_BIT( ch->act, PLR_AFK );
/*
          act( AT_GREY, "$n is no longer afk.", ch, NULL, NULL, TO_ROOM );
*/
          act( AT_GREY, "$n is no longer afk.", ch, NULL, NULL, TO_CANSEE );
	}


The reason for the extra IS_NPC check is because the PLR_* and ACT_* flag sets share the same ch->act pointer and the PLR_AFK check could potentially be triggered in error by a mob with the right ACT_* flag set.
       
Pages:<< prev 1 next >>