Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Bing

Members: 0
Guests: 15
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Clan member count is no...
Forum Rules | Mark all | Recent Posts

[Bug] Clan member count is not safeguarded against going negative
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 9, 2005 11:33 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Clan member count is not safeguarded against going negative in do_mset and do_outcast
Danger: Low - Incorrect counter value
Found by: Celestria
Fixed by: Celestria

---

build.c, do_mset

Locate:

      if( !arg3 || arg3[0] == '\0' )
      {
         if( victim->pcdata->clan == NULL )
            return;
         remove_member( victim->name, victim->pcdata->clan->shortname );
         STRFREE( victim->pcdata->clan_name );
         victim->pcdata->clan_name = STRALLOC( "" );
         victim->pcdata->clan = NULL;
         send_to_char
            ( "Removed from clan.\n\rPlease make sure you adjust that clan's members accordingly.\n\rAlso be sure to remove any bestowments they have been given.\n\r",
              ch );
         return;
      }


Change to:

      if( !arg3 || arg3[0] == '\0' )
      {
         if( victim->pcdata->clan == NULL )
            return;
         remove_member( victim->name, victim->pcdata->clan->shortname );
         --victim->pcdata->clan->members; 
         save_clan( victim->pcdata->clan );
         STRFREE( victim->pcdata->clan_name );
         victim->pcdata->clan_name = STRALLOC( "" );
         victim->pcdata->clan = NULL;
         send_to_char( "Removed from clan.\n\r", ch );
         return;
      }


Locate:

      if( victim->pcdata->clan )
         remove_member( victim->name, victim->pcdata->clan->shortname );

      STRFREE( victim->pcdata->clan_name );
      victim->pcdata->clan_name = QUICKLINK( clan->name );
      victim->pcdata->clan = clan;
      add_member( victim->name, victim->pcdata->clan->shortname );
      send_to_char( "Done.\n\rPlease make sure you adjust that clan's members accordingly.\n\r", ch );


Change to:

      if( victim->pcdata->clan )
         remove_member( victim->name, victim->pcdata->clan->shortname );

      --victim->pcdata->clan->members; 
      if( victim->pcdata->clan->members < 0 )
         victim->pcdata->clan->members = 0;
      save_clan( victim->pcdata->clan );

      STRFREE( victim->pcdata->clan_name );
      victim->pcdata->clan_name = QUICKLINK( clan->name );
      victim->pcdata->clan = clan;
      add_member( victim->name, victim->pcdata->clan->shortname );
      save_clan( victim->pcdata->clan );
      send_to_char( "Done.\n\r", ch );


clans.c, do_outcast

Locate:

/*    if ( victim->speaking & LANG_CLAN )
        victim->speaking = LANG_BASIC;
    REMOVE_BIT( victim->speaks, LANG_CLAN );*/
   --clan->members;


Change to:

/*    if ( victim->speaking & LANG_CLAN )
        victim->speaking = LANG_BASIC;
    REMOVE_BIT( victim->speaks, LANG_CLAN );*/
    --clan->members;
    if( clan->members < 0 )
       clan->members = 0;


Accuracy of clan membership information is somewhat important.
       
Pages:<< prev 1 next >>