Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing

Members: 0
Guests: 18
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
tphegley (37)
Related Links
» SmaugMuds » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Bestow command handles ...
Forum Rules | Mark all | Recent Posts

[Bug] Bestow command handles arguments improperly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 5, 2005 9:51 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Bestow command handles arguments improperly
Danger: Low - Cuts of a portion of input argument
Found by: Remcon
Fixed by: Remcon

---

act_wiz.c, do_bestow

Locate:
   char arg[MAX_INPUT_LENGTH], buf[MAX_STRING_LENGTH], arg_buf[MAX_STRING_LENGTH];
   CHAR_DATA *victim;


Change to:
   char arg[MAX_INPUT_LENGTH], buf[MAX_STRING_LENGTH], arg_buf[MAX_STRING_LENGTH];
   char tmparg[MAX_INPUT_LENGTH];
   CHAR_DATA *victim;


Locate:
      sprintf( arg, "%s ", arg );
      strcat( arg_buf, arg );
      argument = one_argument( argument, arg );


Change to:
      snprintf( tmparg, MAX_INPUT_LENGTH, "%s ", arg );
      strncat( arg_buf, tmparg, MAX_STRING_LENGTH );
      argument = one_argument( argument, arg );


This fixes the sizing of the arg_buf string which then lets the command do everything it is intended to do.
       
Pages:<< prev 1 next >>