Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing, Google

Members: 0
Guests: 15
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Some of the stat retrei...
Forum Rules | Mark all | Recent Posts

[Bug] Some of the stat retreival functions do not initialize properly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jan 22, 2006 6:26 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Some of the stat retreival functions do not initialize properly
Danger: Medium - Working with uninitialized values is undefined and probably not what you want.
Found by: Valgrind
Fixed by: Samson

---

handler.c

Locate:
/*
 * Retrieve character's current dexterity.
 */
short get_curr_dex( CHAR_DATA * ch )
{
   short max;
   max = UMIN( max, 25 );

   max = 20 + race_table[ch->race].dex_plus;

   return URANGE( 3, ch->perm_dex + ch->mod_dex, max );
}

/*
 * Retrieve character's current constitution.
 */
short get_curr_con( CHAR_DATA * ch )
{
   short max;
   max = UMIN( max, 25 );

   max = 20 + race_table[ch->race].con_plus;

   return URANGE( 3, ch->perm_con + ch->mod_con, max );
}

/*
 * Retrieve character's current charisma.
 */
short get_curr_cha( CHAR_DATA * ch )
{
   short max;
   max = UMIN( max, 25 );

   max = 20 + race_table[ch->race].cha_plus;

   return URANGE( 3, ch->perm_cha + ch->mod_cha, max );
}


Change to:
/*
 * Retrieve character's current dexterity.
 */
short get_curr_dex( CHAR_DATA * ch )
{
   short max;

   max = 20 + race_table[ch->race].dex_plus;
   max = UMIN( max, 25 );

   return URANGE( 3, ch->perm_dex + ch->mod_dex, max );
}

/*
 * Retrieve character's current constitution.
 */
short get_curr_con( CHAR_DATA * ch )
{
   short max;

   max = 20 + race_table[ch->race].con_plus;
   max = UMIN( max, 25 );

   return URANGE( 3, ch->perm_con + ch->mod_con, max );
}

/*
 * Retrieve character's current charisma.
 */
short get_curr_cha( CHAR_DATA * ch )
{
   short max;

   max = 20 + race_table[ch->race].cha_plus;
   max = UMIN( max, 25 );

   return URANGE( 3, ch->perm_cha + ch->mod_cha, max );
}


The 3 functions above are used in a number of calculations throughout the game and can have serious side affects if the system uses the uninitalized max value and ends up thinking it should be 25 instead of what it really is.
       
Pages:<< prev 1 next >>