Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing

Members: 0
Guests: 18
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Port numbers sometimes ...
Forum Rules | Mark all | Recent Posts

[Bug] Port numbers sometimes show up in logs with negative values
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 30, 2006 9:41 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Port numbers sometimes show up in logs with negative values
Danger: Trivial - Display only bug.
Found by: Remcon
Fixed by: Remcon

---

comm.c, new_descriptor

Locate:
   log_printf_plus( LOG_COMM, sysdata.log_level, "Sock.sinaddr:  %s, port %hd.", buf, dnew->port );


Change to:
   log_printf_plus( LOG_COMM, sysdata.log_level, "Sock.sinaddr:  %s, port %d.", buf, dnew->port );


This is a very subtle one to spot, but it makes all the difference when displaying the value. %hd is the formatting tag for a signed short, while %d is the formatting tag for an int. Since port numbers can go to 65535, a signed short isn't the proper size to display it.
       
Pages:<< prev 1 next >>