Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Google

Members: 0
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Memory leaks in load_mo...
Forum Rules | Mark all | Recent Posts

[Bug] Memory leaks in load_mobile during a hotboot
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 25, 2006 9:58 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Memory leaks in load_mobile during a hotboot
Danger: Medium - Memory leak. Can lead to other problems if left alone.
Found by: Remcon
Fixed by: Remcon

---

hotboot.c, load_mobile

Locate:
            KEY( "Description", mob->description, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Description" ) )
            {
               STRFREE( mob->description );
               mob->description = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Long", mob->long_descr, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Long" ) )
            {
               STRFREE( mob->long_descr );
               mob->long_descr = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Mobclan", mob->mob_clan, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Mobclan" ) )
            {
               STRFREE( mob->mob_clan );
               mob->mob_clan = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Name", mob->name, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Name" ) )
            {
               STRFREE( mob->name );
               mob->name = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Short", mob->short_descr, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Short" ) )
            {
               STRFREE( mob->short_descr );
               mob->short_descr = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Though minor, memory leaks can still cause other problems if not dealt with. Best not to ignore them when found.
       
Pages:<< prev 1 next >>