Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Bing

Members: 0
Guests: 19
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
tphegley (37)
Related Links
» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Chess games don't clean...
Forum Rules | Mark all | Recent Posts

[Bug] Chess games don't clean up properly when one player quits
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 11, 2007 1:13 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Chess games don't clean up properly when one player quits
Danger: High - Crash bug. If the other game player tries to end the game, the MUD crashes.
Found by: Findecano
Fixed by: Findecano

---

chess.c, free_game

Locate the function and replace it with:
void free_game( GAME_BOARD_DATA * board )
{
   if( !board )
      return;

#ifdef IMC
   if( board->type == TYPE_IMC )
   {
      imc_send_chess( board->player1 ? board->player1 : NULL, board->player2, "stop" );
      STRFREE( board->player2 );
   }
#endif

   if( board->player1 )
   {
      if( CHAR_DATA *ch = get_char_world( supermob, board->player1 ) ) // Added for bugfix - Findecano 23/11/07
      {
         ch_printf( ch, "The game has been stopped at %d total moves.\r\n", board->turn );
         ch->pcdata->game_board = NULL;
      }
   }

   if( board->player2 )
   {
      if( CHAR_DATA *ch = get_char_world( supermob, board->player2 ) ) // Added for bugfix - Findecano 23/11/07
      {
         ch_printf( ch, "The game has been stopped at %d total moves.\r\n", board->turn );
         ch->pcdata->game_board = NULL;
      }
   }
   STRFREE( board->player1 );
   STRFREE( board->player2 );
   DISPOSE( board );
}


When someone quits in the middle of a chess game, the code for stopping the game via "chess cease" did not have any safety checks against NULL participants. It would then crash the MUD when trying to send messages to invalid targets.
       
Pages:<< prev 1 next >>