Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Bing

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
tphegley (37)
Related Links
» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Disenchant weapon crash...
Forum Rules | Mark all | Recent Posts

[Bug] Disenchant weapon crashes the game when cast
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 20, 2008 3:29 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,647
JoinedJan 1, 2002

Bug: Disenchant weapon crashes the game when cast
Danger: Critical - Game crash.
Found by: Kayle
Fixed by: Remcon

---

magic.c, spell_disenchant_weapon

Locate:
   for( paf = obj->first_affect; paf; paf = paf->next )
   {
      paf_next = paf->next;
      if( paf->location == APPLY_HITROLL || paf->location == APPLY_DAMROLL )
      {
         UNLINK( paf, obj->first_affect, obj->last_affect, next, prev );
         DISPOSE( paf );
      }
   }


Change to:
   for( paf = obj->first_affect; paf; paf = paf_next )
   {
      paf_next = paf->next;
      if( paf->location == APPLY_HITROLL || paf->location == APPLY_DAMROLL )
      {
         UNLINK( paf, obj->first_affect, obj->last_affect, next, prev );
         DISPOSE( paf );
      }
   }


This is one of those classic "oops" moments where the list is being manipulated incorrectly. The proper fix was even being kept in mind, it's just too bad that the for loop wasn't using it.
       
Pages:<< prev 1 next >>