Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
question on overland code
May 31, 2018 12:03 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Google

Members: 0
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
483
3,743
19,401
655
RodrickMci
Today's Birthdays
tphegley (37)
Related Links
» SmaugMuds » Codebases » SWR FUSS » Memory leaks in fread_planet()
Forum Rules | Mark all | Recent Posts

Memory leaks in fread_planet()
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 20, 2009 12:09 pm
Go to the top of the page
Go to the bottom of the page

Caius
Magician
GroupMembers
Posts132
JoinedJan 29, 2006

In fread_planet, under "GovernedBy" the return value of fread_string() is fed directly into get_clan().

if( !str_cmp( word, "GovernedBy" ) )
{
  planet->governed_by = get_clan( fread_string( fp ) );
  fMatch = TRUE;
}


Since fread_string() STRALLOCs it, this memory is never freed. A possible solution is rewriting it as such:

if( !str_cmp( word, "GovernedBy" ) )
{
  char *clan_name = fread_string( fp );
  planet->governed_by = get_clan( clan_name );
  fMatch = TRUE;
  STRFREE( clan_name );
}


The same applies to "Starsystem" a few lines below.
       
Post is unread #2 Dec 8, 2009 5:26 am
Go to the top of the page
Go to the bottom of the page

Caius
Magician
GroupMembers
Posts132
JoinedJan 29, 2006

Seems like this was already reported in this thread. Sowwy...
       
Pages:<< prev 1 next >>