Login
User Name:

Password:



Register

Forgot your password?
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, Bing, AhrefsBot, SemrushBot, DotBot

Members: 0
Guests: 3
Stats
Files
Topics
Posts
Members
Newest Member
486
3,758
19,453
572
danielw

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » AFKMud Bugfix List » [Bug] Failed object invocatio...
Forum Rules | Mark all | Recent Posts

[Bug] Failed object invocation results in a memory leak
< Newer Topic :: Older Topic > AFKMud 2.01

Pages:<< prev 1 next >>
Post is unread #1 Oct 14, 2007 12:14 pm   
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,665
JoinedJan 1, 2002

 
Bug: Failed object invocation results in a memory leak
Danger: Low - Memory leak under specific conditions
Discovered in: AFKMud 2.01
Found by: Samson
Fixed by: Samson

---

act_wiz.cpp, objinvoke

Locate:
      if( !ch->is_imp(  ) )
      {
         ch->print( "Loading of rare items is restricted to KLs and above on this port.\r\n" );
         return;
      }


Change to:
      if( !ch->is_imp(  ) )
      {
         ch->print( "Loading of rare items is restricted to KLs and above on this port.\r\n" );
         obj->extract(); // It got created, now we need to destroy it.
         return;
      }


Simple oversight. If the multiport functions are enable and someone who is below the admin level tries to load a rare item, they get told they can't do that on the main game port. That object still got generated in memory and was still added to the global object list. But it has not been placed in an inventory or in a room. It is essentially left dangling. Needless to say this results in a memory leak of sorts, even though the object is technically still reachable by the update loops.

Pages:<< prev 1 next >>