Login
User Name:

Password:



Register

Forgot your password?
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, Bing, SemrushBot, Yandex, AhrefsBot, Google

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
486
3,758
19,453
572
danielw

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » AFKMud Bugfix List » [Bug] Line editor crashes whe...
Forum Rules | Mark all | Recent Posts

[Bug] Line editor crashes when overfilled
< Newer Topic :: Older Topic > AFKMud 2.01

Pages:<< prev 1 next >>
Post is unread #1 Oct 14, 2007 12:13 pm   
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,665
JoinedJan 1, 2002

 
Bug: Line editor crashes when overfilled
Danger: Critical - Buffer overrun crash
Discovered in: AFKMud 2.01
Found by: John
Fixed by: Samson

---

editor.cpp, in struct editor_data

Locate:
   char line[49][81];


Change to:
   char line[max_buf_lines][81];


editor.cpp, char_data::start_editing

Locate:
         if( lines >= 49 || size > 4096 )


Change to:
         if( lines >= max_buf_lines || size > MSL )


Locate:
   if( lpos > 0 && lpos < 78 && lines < 49 )


Change to:
   if( lpos > 0 && lpos < 78 && lines < max_buf_lines )


editor.cpp, start_editing

Locate:
         if( lines >= 49 || size > 4096 )


Change to:
         if( lines >= max_buf_lines || size > MSL )


Locate:
   if( lpos > 0 && lpos < 78 && lines < 49 )


Change to:
   if( lpos > 0 && lpos < 78 && lines < max_buf_lines )


Classic case of not catching everything that needed to get changed. At some point along the way we decided to make it easier for us to change the number of lines a line editor can hold from 49 to 60. Don't remember exactly why, but we did. In doing so I decided to make the number of lines easily changed from one spot but forgot about other places the original 49 was used. So the code was trying to treat a 49 line buffer as though it had 60 lines, which is a Bad Thing(tm).

Pages:<< prev 1 next >>