Login
User Name:

Password:



Register

Forgot your password?
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, AhrefsBot, Bing

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
486
3,766
19,510
575
Zedethar

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Codebases » SmaugFUSS » Bugs found in Smaugfuss1.9.3
Forum Rules | Mark all | Recent Posts

Bugs found in Smaugfuss1.9.3
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 21, 2021 10:17 pm   Last edited Feb 22, 2021 2:22 am by Zedethar
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
Greetings all,

I just recently compiled this 1.9.4 version and upon logging into the game I notice 2 bugs.

After getting a few levels, s no longer works for south, It suddenly says "I have no house to sell" I am guessing the sellhouse function is overriding.
Also config +automap once the map is in place it breaks the room descriptions turning them invisible on most sentences..
----------

I managed to fix the south confliction with sellhouse by changing it to hsell. That takes care of that. I also put say before sayto so it would pop up first.
With sayto coming first it broke my mobprogs that use Say so This will work better for me.
The only way I could fix the automap room description break was to revert back to 1.9.3 (it still works great on this one)


Update: death/mortally wounded bug found 1.9.3
I've found another bug for mortals at least. After getting knocked to mortally wounded which happens alot in my opinion. The hp jumps from 0 but beyond
that it jumped to 4999500+ .. I mstat'd the player and it wasnt true, it was actually -9. Is there a way to fix this? Or remove mortally wounded and let
it go straight to death beyond 0??

----------------------------------------------------------------------------
LEVEL: 11 Race : Orc Played: 1 hours
YEARS: 17 Class: Warrior Log In: Mon Feb 22 02:06:20 2021
STR : 19(17) Saved: Mon Feb 22 02:18:25 2021
INT : 15(11) Time: Mon Feb 22 02:20:00 2021
WIS : 16(10) Armor: shabby and threadbare
DEX : 17(13) Align: +0000, neutral Items: 00006 (max 00007)
CON : 20(15) Pos'n: incapacitated Weight: 00018 (max 0000400)
CHA : 11(11) Wimpy: 0 Style: standard
LCK : 12(12)
Glory: 0000(0000)
PRACT: 014 Hitpoints: -4 of 209 Pager: ( ) 60 AutoExit(X)
XP : 1221807 MKills: 00101 AutoLoot( )
GOLD : 2,522 Move: 95 of 200 Mdeaths: 00000 AutoSac ( )
You feel great.
Languages: common orcish
----------------------------------------------------------------------------
Deity: Helm Favor: ignored
----------------------------------------------------------------------------
AFFECT DATA: [true sight ]
[stone skin ]

<4294967292hp 91m 95mv>

Post is unread #2 Feb 22, 2021 10:14 am   
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts82
JoinedAug 25, 2003

 
I don't know, I took a look at the fly and it seems to me that in comm.c you have in the display_prompt:

unsigned int pstat;

try to change it with:

int pstat;

and then further down change the output:

 if (pstat! = 0x7FFFFFFF)
            snprintf (pbuf, MAX_STRING_LENGTH - strlen (buf), "% d", pstat);


a closer look should be taken.
see if it goes

bye!


Post is unread #3 Feb 22, 2021 10:15 am   
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts82
JoinedAug 25, 2003

 
"%d" without space "% d"

Post is unread #4 Feb 22, 2021 11:01 pm   
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
I found this line in my comm.c is this relevant to the mortally wounded function?
if( pstat != 0x80000000 )
snprintf( pbuf, MAX_STRING_LENGTH - strlen (buf), "%u", pstat );
pbuf += strlen( pbuf );

Post is unread #5 Feb 23, 2021 3:05 am   Last edited Feb 23, 2021 3:06 am by Matteo2303
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts82
JoinedAug 25, 2003

 
Zedethar said:

I found this line in my comm.c is this relevant to the mortally wounded function?
if( pstat != 0x80000000 )
snprintf( pbuf, MAX_STRING_LENGTH - strlen (buf), "%u", pstat );
pbuf += strlen( pbuf );


It's relevant about all prompt display: try to change unsignend int pstat to int, change 0x80000000 with 0x7FFFFFFF and %u with %d.

int pstat;
<....etc...>
if( pstat != 0x7FFFFFFF )
snprintf( pbuf, MAX_STRING_LENGTH - strlen (buf), "%d", pstat );
pbuf += strlen( pbuf );


II don't have your code, look if this work and prompt display -1. -2, etc.. hp

Post is unread #6 Feb 23, 2021 4:12 am   
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
So far my tests conclude that the problem is fixed! Thank you so much sir. I will report back if i see the bug. It shows -2 -5 and so on. No ODD numbers now.

:)

Post is unread #7 Feb 23, 2021 5:41 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,899
JoinedJul 26, 2005

 
thats a good find. Later on you normally don't go -, so guess it has went unnoticed. a - on an unsigned makes it wrap around and give an out of wack number lol

Post is unread #8 Mar 1, 2021 8:35 pm   
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
Found a critical bug in 1.9.3 hopefully fixed in updates.

Any new character that uses the command Favor without devoting to a deity crashes the mud. Let me know if this was fixed or how I could possibly stop it. I disabled Favor for now.

Post is unread #9 Mar 2, 2021 10:16 am   
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
Also found another bug 1.9.3 occurring when you use the makeclan command. This causes the mud to also crash. Is there a crashlog I can refer to so I can attempt to fix some of these?

Thanks

Post is unread #10 Mar 2, 2021 4:46 pm   
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts82
JoinedAug 25, 2003

 
Zedethar said:

Found a critical bug in 1.9.3 hopefully fixed in updates.

Any new character that uses the command Favor without devoting to a deity crashes the mud. Let me know if this was fixed or how I could possibly stop it. I disabled Favor for now.


In do_favour

change the first ifcheck with:

if( !ch->pcdata->deity )
{
ch_printf( ch, "Dovresti prima consacrarti a qualche divinita'.\n\r" ); //
return;
}

Post is unread #11 Mar 2, 2021 5:10 pm   
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts82
JoinedAug 25, 2003

 
Zedethar said:

Also found another bug 1.9.3 occurring when you use the makeclan command. This causes the mud to also crash. Is there a crashlog I can refer to so I can attempt to fix some of these?

Thanks


in function get_clan change in this way:

if( !str_cmp( name, clan->name ) || ( clan->abbrev && ( clan->abbrev[0] != '\0' ) && !str_cmp( name, clan->abbrev ) ) )


probably get_council and others need the same check.
I don't know... It's not my codebase sorry

bye!

Post is unread #12 Mar 2, 2021 7:45 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,899
JoinedJul 26, 2005

 
Yeah looks like it isn't protecting against a few things and as matteo said protecting against things make all the difference.

Post is unread #13 Mar 2, 2021 8:51 pm   Last edited Mar 2, 2021 9:42 pm by Zedethar
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
Matteo2303 said:

Zedethar said:

Found a critical bug in 1.9.3 hopefully fixed in updates.

Any new character that uses the command Favor without devoting to a deity crashes the mud. Let me know if this was fixed or how I could possibly stop it. I disabled Favor for now.


In do_favour

change the first ifcheck with:

if( !ch->pcdata->deity )
{
ch_printf( ch, "Dovresti prima consacrarti a qualche divinita'.\n\r" ); //
return;
}



Is this located in deity.c ?? This is mine. I can't seem to locate the do_favor but I found the other cmds like do_supplicate and do_devote. Is mine missing?

void do_devote( CHAR_DATA* ch, const char* argument)
{
char arg[MAX_INPUT_LENGTH];
DEITY_DATA *deity;

if( IS_NPC( ch ) )
{
send_to_char( "Huh?\r\n", ch );
return;
}

if( ch->level < 5 )
{
send_to_char( "You are not yet prepared for such devotion.\r\n", ch );
return;
}

argument = one_argument( argument, arg );

if( arg[0] == '\0' )
{
send_to_char( "Devote yourself to which deity?\r\n", ch );
return;
}

if( !str_cmp( arg, "none" ) )
{
AFFECT_DATA af;
if( !ch->pcdata->deity )
{
send_to_char( "You have already chosen to worship no deities.\r\n", ch );
return;
}

Post is unread #14 Mar 2, 2021 9:19 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,899
JoinedJul 26, 2005

 
you can find do_favor in player.c

Post is unread #15 Mar 2, 2021 9:19 pm   Last edited Mar 2, 2021 9:49 pm by Zedethar
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
Matteo2303 said:

Zedethar said:

Also found another bug 1.9.3 occurring when you use the makeclan command. This causes the mud to also crash. Is there a crashlog I can refer to so I can attempt to fix some of these?

Thanks


in function get_clan change in this way:

if( !str_cmp( name, clan->name ) || ( clan->abbrev && ( clan->abbrev[0] != '\0' ) && !str_cmp( name, clan->abbrev ) ) )


probably get_council and others need the same check.
I don't know... It's not my codebase sorry

bye!


I have found this part in my section in clans.c (heres what mine looked like)

CLAN_DATA *get_clan( const char *name )
{
CLAN_DATA *clan;

for( clan = first_clan; clan; clan = clan->next )
if( !str_cmp( name, clan->name ) || ( ( clan->abbrev[0] != '\0' ) && !str_cmp( name, clan->abbrev ) ) )
return clan;
return NULL;
}

I am changing it to yours. This worked successfully!
Thanks for help!

Post is unread #16 Mar 2, 2021 10:01 pm   
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
For Donation rooms, I don't know if this is a bug yet.
Do they save automatically or at certain times? I have my first donation room with donation flag set. But after every reboot it wipes all items. Is there something else I need to flag?

Post is unread #17 Mar 3, 2021 4:48 am   
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts82
JoinedAug 25, 2003

 
Zedethar said:

For Donation rooms, I don't know if this is a bug yet.
Do they save automatically or at certain times? I have my first donation room with donation flag set. But after every reboot it wipes all items. Is there something else I need to flag?


I don't think the room_donation flag is used for what you think. It seems to me that it only prevents the "get all" in the location where it is placed.

Instead it seems to me that the function that could do what you want is the void save_storeroom (CHAR_DATA * ch, int vnum)
in clans.c

NOTE: going from memory I searched for save_clan_storeroom which is actually declared in mud.h in smaugfuss even if the function does not exist anywhere. You might take the statement off I suppose.

Hi!

Post is unread #18 Mar 3, 2021 7:49 am   
Go to the top of the page
Go to the bottom of the page

Zedethar
Fledgling
GroupMembers
Posts22
JoinedFeb 21, 2021

 
Donation room is fixed! I managed to try various commands and found this:

Setvault (vnum) create - this command created it

then I Setflags for room
Room flags: safe donation clanstoreroom nosummon

After a reboot I managed to make it save. This works if anyone is trying to get donation rooms saving.
Thanks

Pages:<< prev 1 next >>