How do we handle the errors caused by gcc4.2? (14 Votes)
Update to const char *argument and adjust all the rest of the code accordingly.
57.14% - 8 votes
Modernize and update to std::string throughout the code.
42.86% - 6 votes
Other. (Post an explanation of your alternative solution.)
0% - 0 votes
How do we handle the errors caused by gcc4.2?
< Newer Topic
:: Older Topic >
#21 Jun 20, 2008 12:02 am
Off the Edge of the Map
GroupAdministrators
Posts1,200
JoinedMar 21, 2006
Fix is in the works. We gotta cut David some slack, He's in the middle of Graduating and I believe moving to New York.
#22 Jun 20, 2008 2:00 am
GroupMembers
Posts903
JoinedJan 29, 2007
Yes... I am in Nevada right now. Most of my days are spent driving and sight-seeing. Making good progress on the fix, though.
#23 Jun 21, 2008 1:00 am
GroupMembers
Posts423
JoinedMar 7, 2005
Hey congrats on graduation, always a fun time and a big transition. I wasn't trying to rush anyone, just worried that maybe I missed the boat or this was already resolved somewhere else. We lurkers have these problems from time to time.
Keep up the good work!
Keep up the good work!
#24 Jun 21, 2008 9:55 am
GroupAdministrators
Posts1,946
JoinedJul 26, 2005
Well I had waited for awhile on it and a few days ago just went ahead and did it myself (granted I don't doubt it could have been done better) I get a clean compile now while using -Wwrite-strings (in cygwin anyways). I didn't do it for smaugfuss though so can't release it, but just figured I'd chime in that you can probably have it done in a few days time.
#25 Jul 10, 2008 2:38 am
GroupMembers
Posts903
JoinedJan 29, 2007
I've finally gotten my computer up and running again and resumed work on this. It's hard to give a percentage since things sneak up on me from time to time, but I think I'll be done soon. I had to put in some "inelegant" casts here and there but overall it's ok.
Now, it's worth noting that this is going to confuse the hell out of people when they're used to being able to modify stuff willy-nilly: the const version is very picky about what you can change and what you can't.
A lesson I've (re-)learned is that I really dislike dealing with strings in C. :sigh:
Now, it's worth noting that this is going to confuse the hell out of people when they're used to being able to modify stuff willy-nilly: the const version is very picky about what you can change and what you can't.
A lesson I've (re-)learned is that I really dislike dealing with strings in C. :sigh:
#26 Jul 10, 2008 6:39 pm
GroupMembers
Posts903
JoinedJan 29, 2007
OK, it's done. Nearly all changes were just adding the const keyword appropriately. There were a few places where I had to do non-trivial changes like make temporary strings, and those are the most likely places where I messed up. (But of course, it is impossible that I messed up... )
Unfortunately, as I don't have my server back yet, I can't distribute it as a nice diff like I had planned to do. I should have it ready in a few days (well, as soon as the shipment arrives, that is).
Unfortunately, as I don't have my server back yet, I can't distribute it as a nice diff like I had planned to do. I should have it ready in a few days (well, as soon as the shipment arrives, that is).
#27 Jul 10, 2008 9:07 pm
Off the Edge of the Map
GroupAdministrators
Posts1,200
JoinedMar 21, 2006
Awesome. Can't wait.
#28 Jul 11, 2008 12:23 am
GroupMembers
Posts423
JoinedMar 7, 2005
I'll second that. I'll surely be patching it in manually from the diff, but I'm still anxiously waiting to do so. Should be nice to have this issue addressed.
Thanks in advanced for all the hard work put into this!
Thanks in advanced for all the hard work put into this!
#29 Jul 15, 2008 2:49 pm
GroupMembers
Posts903
JoinedJan 29, 2007
Apparently my server box was delivered today, so tonight I'll be able to put it together and hopefully have it online. If I can't get it online tonight (a distinct possibility given that I'll probably get home late after work) I'll just release the src as a .tgz so people can take a look at it with their own diff tools or whatever.
#30 Jul 15, 2008 7:18 pm
Off the Edge of the Map
GroupAdministrators
Posts1,200
JoinedMar 21, 2006
Eh, one more day wouldn't kill any of us.
#31 Jul 15, 2008 10:11 pm
GroupMembers
Posts870
JoinedMay 8, 2005
Kayle said:
Eh, one more day wouldn't kill any of us.
Seconded.
#32 Jul 15, 2008 10:32 pm
GroupMembers
Posts903
JoinedJan 29, 2007
Shipment didn't arrive today even though it was scheduled to. :sigh: And since people seem ok with waiting a little bit more, and since I'm feeling exhausted, I'll take care of archiving and uploading tomorrow.
#33 Jul 15, 2008 10:39 pm
Off the Edge of the Map
GroupAdministrators
Posts1,200
JoinedMar 21, 2006
Personally, I'm willing to wait for your diffs on the server.
#34 Jul 17, 2008 10:53 am
GroupMembers
Posts62
JoinedAug 30, 2005
DavidHaley said:
I've finally gotten my computer up and running again and resumed work on this. It's hard to give a percentage since things sneak up on me from time to time, but I think I'll be done soon. I had to put in some "inelegant" casts here and there but overall it's ok.
Now, it's worth noting that this is going to confuse the hell out of people when they're used to being able to modify stuff willy-nilly: the const version is very picky about what you can change and what you can't.
A lesson I've (re-)learned is that I really dislike dealing with strings in C. :sigh:
Ah, come on, C strings are great!
Glad to see the drive across the country didn't gobble you up. Welcome to good old *cough* New York. That's the smog, not clouds. :-)
#35 Jul 21, 2008 11:22 am
GroupMembers
Posts903
JoinedJan 29, 2007
Is the version of FUSS available for download the most recent one? I'm going to get a fresh copy and then apply my changes to make sure things still compile.
The server is up, I just forgot to open the firewall and I can't do that from work... d'oh.
The server is up, I just forgot to open the firewall and I can't do that from work... d'oh.
#36 Jul 21, 2008 2:20 pm
Black Hand
GroupAdministrators
Posts3,697
JoinedJan 1, 2002
Yes, it's the most recent. There haven't been any confirmed additional fixes that need to be placed since the last one was posted some time ago.
#37 Jul 22, 2008 9:08 am
GroupMembers
Posts723
JoinedMar 5, 2005
This fix was applied?
http://smaugmuds.afkmods.com/index.php?a=topic&t=3701
http://smaugmuds.afkmods.com/index.php?a=topic&t=3701
#38 Jul 23, 2008 12:26 am
GroupMembers
Posts903
JoinedJan 29, 2007
The patch is available here: http://binarygoblins.dyndns.org:8088/.
Here is a direct link to the diff.
Here is a direct link to the diff.
#39 Jul 23, 2008 1:04 am
Black Hand
GroupAdministrators
Posts3,697
JoinedJan 1, 2002
I don't mean to sound like an idiot, but.... which one of these is supposed to be FUSS 1.9 with the const fix applied? Your link to the patch leads to several repositories, not a downloadable file.
#40 Jul 23, 2008 9:41 am
GroupMembers
Posts903
JoinedJan 29, 2007
Sorry that that wasn't clear. The current version is always in 'stable', and the one with the fix applied is 'stable-const'.