Login
User Name:

Password:



Register

Forgot your password?
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, Bing, AhrefsBot

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
486
3,766
19,510
575
Zedethar

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Codebases » SWR FUSS » move_char bug with positions
Forum Rules | Mark all | Recent Posts

move_char bug with positions
< Newer Topic :: Older Topic >

Pages:<< prev 1, 2 next >>
Post is unread #21 Aug 2, 2010 5:21 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
Conner said:

Sorry, Kayle, I'm pretty much in the same boat over here. If I put it in, I've still got to try to test it somehow by my lonesome too. My mud's not exactly been crowded to capacity since my move to the country that mandated switching to this damn laggy satellite feed. :(

Yeah, neither of mine are open, and with work, I lack the time I used to have to thoroughly test things before posting them. I do have some active staff members though, I probably could have gotten them to test it. But Meh, that's hindsight for you.


Sharmair said:

Stuffs.

Thanks Sharmair.

It felt wrong to me as well to toss all those checks into move_char when the actual problem lies with auto-exits themselves not the actual movement of the character. I hadn't stopped to think about the fall through from the check being where I had it though, so that was another good catch on your part. I guess that's good enough confirmation for me that using a check_pos() call on the auto-exits is enough to fix this issue. So I'll see about getting an actual fix posted soon.

Post is unread #22 Aug 2, 2010 8:01 pm   
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

 
Aint hindsight wonderous? ;)

So, does this address things like being pulled through an exit by room settings (See also help PULLTYPES) as well as flee, being dragged, etc now?

Post is unread #23 Aug 2, 2010 8:08 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
My/Sharmair's fix only affects auto-exits.

Applying the original fix will disrupt flee. I dunno about pulltypes, I would assume it would disrupt those as well though.

That's why I was uneasy about applying the fix to move_char, too many things use move_char that fixing it directly in there will break things other than fixing just the issue, if you apply a targeted fix, for instance, a check_pos() call in the interpret function in the section for auto-exits, you fix the issue, without breaking any other things.

Post is unread #24 Aug 2, 2010 8:30 pm   
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,668
JoinedJan 1, 2002

 
Second (or 3rd now?) Kayle's logic. move_char() is a pretty big catch-all function for an awful lot of things. Fleeing being one, pulltypes another, and I'm sure there's probably other stuff that hasn't been noticed yet. Basically it would disrupt anything where the assumption is the move will happen regardless.

So fixing the problem in the auto-exit code looks like the better option.

Post is unread #25 Aug 3, 2010 12:37 pm   
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

 
So, does that mean we're adopting one of these proposed fixes as official then?

Post is unread #26 Aug 3, 2010 7:38 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
Yeah, I'll get it posted and released hopefully tomorrow after work.

Post is unread #27 Aug 4, 2010 11:39 pm   
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

 
Sounds good. :)

Pages:<< prev 1, 2 next >>