Login
User Name:

Password:



Register

Forgot your password?
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 3
Stats
Files
Topics
Posts
Members
Newest Member
486
3,754
19,440
576
relotnek

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » General » Coding » smaugfuss 1.9.4
Forum Rules | Mark all | Recent Posts

smaugfuss 1.9.4
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 12, 2020 4:18 am   Last edited May 12, 2020 4:20 am by Matteo2303
Go to the top of the page
Go to the bottom of the page

Matteo2303
Apprentice
GroupMembers
Posts69
JoinedAug 25, 2003

 
Hi, I downloaded for a comparison I think the last smaugfuss and I accidentally dropped my eye on the fread_comment.

I admit that I have not tried to compile and check on 1.94 but in my opinion this part of the code lacks what I added in red otherwise I do not see how the double linked list can form
      if( str_cmp( fread_word( fp ), "text" ) )
         break;
      pnote->text = fread_string( fp );

	pnote->next		= ch->comments;


      /*
       * Fixed a big bug here - Luc 08/2000 
       */
      if( pnote->next )
         pnote->next->prev = pnote;

      pnote->prev = NULL;
      ch->comments = pnote;
      return;



Otherwise the list will be produced but the recursive element will be missing and when you go to use the remove_comment it will delete half the list according to the note you are going to remove. I belive... BYE!

Pages:<< prev 1 next >>