Login
User Name:

Password:



Register

Forgot your password?
Changes list / Addchange
Author: Khonsu
Submitted by: Khonsu
6Dragons mp3 sound pack
Author: Vladaar
Submitted by: Vladaar
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
Users Online
Google, Bing

Members: 0
Guests: 32
Stats
Files
Topics
Posts
Members
Newest Member
488
3,788
19,631
595
Khonsu

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Characters not saved in...
Forum Rules | Mark all | Recent Posts

[Bug] Characters not saved in do_clan_withdraw/do_clan_donate
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 4, 2010 5:09 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,200
JoinedMar 21, 2006

 
Bug: Characters not saved in do_clan_withdraw/do_clan_donate
Danger: Medium - Could possibly be abused to drain or inflate a clans funds.
Found by: Caius
Fixed by: Kayle

---

clans.c, do_clan_withdraw
Find:
   clan->funds -= amount;
   ch->gold += amount;
   save_clan( clan );


Replace with:
   clan->funds -= amount;
   ch->gold += amount;
   save_char_obj( ch );


clans.c, do_clan_donate
Find:
   clan->funds += amount;
   ch->gold -= amount;
   save_clan( clan );


Replace with:
   clan->funds += amount;
   ch->gold -= amount;
   save_char_obj( ch );


save_char_obj will save the character, and will call save_clan. So this kills two birds with one stone.

Pages:<< prev 1 next >>