Login
User Name:

Password:



Register

Forgot your password?
Overland with Bitmaps
Jul 4, 2025 11:57 pm
By Samson
void nanny_get_new_race -- comm.c
Mar 13, 2025 7:08 am
By Elwood
IPv6
Jan 25, 2025 10:45 pm
By Samson
mudstrlcpy and mudstrlcat
Jan 18, 2025 5:23 pm
By Samson
I3 and IMC
Jan 17, 2025 9:35 pm
By Samson
SWFotEFUSS 1.5.3
Author: Various
Submitted by: Samson
SWRFUSS 1.4.3
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.8
Author: Various
Submitted by: Samson
AFKMud 2.5.2
Author: AFKMud Team
Submitted by: Samson
SmaugFUSS 1.9.7
Author: Various
Submitted by: Samson
Users Online
Anthropic, AhrefsBot, Amazonbot, Bing, DotBot

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
507
3,812
19,725
594
Bardecome

» SmaugMuds » Codebases » SmaugFUSS » Bug in do_drag( )
Forum Rules | Mark all | Recent Posts

Bug in do_drag( )
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 8, 2017 2:40 am   
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts429
JoinedMar 7, 2005

 
Another oddity that has apparently gone long unnoticed, probably since it doesn't happen that often in practice.

In particular, check out clans.c, function do_drag( ), you'll find this section:

   nogo = FALSE;
   if( ( pexit = get_exit( ch->in_room, exit_dir ) ) == NULL )
      nogo = TRUE;
   else
      if( IS_SET( pexit->exit_info, EX_CLOSED )
          && ( !IS_AFFECTED( victim, AFF_PASS_DOOR ) || IS_SET( pexit->exit_info, EX_NOPASSDOOR ) ) )
      nogo = TRUE;
   if( nogo )
   {
      send_to_char( "There's no exit in that direction.\r\n", ch );
      return;
   }


It probably doesn't make much sense to only check if the victim can pass thru a closed exit, rather than checking the victim AND the ch doing the dragging, since at the end of do_drag( ), both will be moved there.

Fortunately the fix is easy:

    nogo = FALSE;
    if ((pexit = get_exit(ch->in_room, exit_dir)) == NULL )
      nogo = TRUE;
    else
    if ( IS_SET(pexit->exit_info, EX_CLOSED) 
    && ( !( IS_AFFECTED(ch, AFF_PASS_DOOR) && IS_AFFECTED( victim, AFF_PASS_DOOR ) )
    ||   IS_SET(pexit->exit_info, EX_NOPASSDOOR)) )
      nogo = TRUE;
    if ( nogo )
    {
    	send_to_char( "There's no exit in that direction.\r\n", ch );
    	return;
    }


That should fix it up. :cool:

Pages:<< prev 1 next >>