Login
User Name:

Password:



Register

Forgot your password?
do_owhere recursive
Author: Khonsu
Submitted by: Khonsu
Changes list / Addchange
Author: Khonsu
Submitted by: Khonsu
6Dragons mp3 sound pack
Author: Vladaar
Submitted by: Vladaar
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
Users Online
AhrefsBot, Bing

Members: 0
Guests: 31
Stats
Files
Topics
Posts
Members
Newest Member
489
3,791
19,644
596
Elwood

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Codebases » SmaugFUSS » Bug in do_drag( )
Forum Rules | Mark all | Recent Posts

Bug in do_drag( )
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 8, 2017 2:40 am   
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts413
JoinedMar 7, 2005

 
Another oddity that has apparently gone long unnoticed, probably since it doesn't happen that often in practice.

In particular, check out clans.c, function do_drag( ), you'll find this section:

   nogo = FALSE;
   if( ( pexit = get_exit( ch->in_room, exit_dir ) ) == NULL )
      nogo = TRUE;
   else
      if( IS_SET( pexit->exit_info, EX_CLOSED )
          && ( !IS_AFFECTED( victim, AFF_PASS_DOOR ) || IS_SET( pexit->exit_info, EX_NOPASSDOOR ) ) )
      nogo = TRUE;
   if( nogo )
   {
      send_to_char( "There's no exit in that direction.\r\n", ch );
      return;
   }


It probably doesn't make much sense to only check if the victim can pass thru a closed exit, rather than checking the victim AND the ch doing the dragging, since at the end of do_drag( ), both will be moved there.

Fortunately the fix is easy:

    nogo = FALSE;
    if ((pexit = get_exit(ch->in_room, exit_dir)) == NULL )
      nogo = TRUE;
    else
    if ( IS_SET(pexit->exit_info, EX_CLOSED) 
    && ( !( IS_AFFECTED(ch, AFF_PASS_DOOR) && IS_AFFECTED( victim, AFF_PASS_DOOR ) )
    ||   IS_SET(pexit->exit_info, EX_NOPASSDOOR)) )
      nogo = TRUE;
    if ( nogo )
    {
    	send_to_char( "There's no exit in that direction.\r\n", ch );
    	return;
    }


That should fix it up. :cool:

Pages:<< prev 1 next >>