Login
User Name:

Password:



Register

Forgot your password?
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, SemrushBot, Bing, Yandex, DotBot

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
486
3,754
19,441
577
AudreyStam

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Memory leak in fread_ob...
Forum Rules | Mark all | Recent Posts

[Bug] Memory leak in fread_obj.
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 5, 2010 12:04 am   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,197
JoinedMar 21, 2006

 
Bug: Memory leak in fread_obj
Danger: Medium - Leak only occurs on incomplete objects
Found by: Remcon
Fixed by: Remcon/Samson

---

save.c, fread_obj
Locate:
               if( !fNest || !fVnum )
               {
                  if( obj->name )
                     bug( "Fread_obj: %s incomplete object.", obj->name );
                  else
                     bug( "%s", "Fread_obj: incomplete object." );
                  if( obj->name )
                     STRFREE( obj->name );
                  if( obj->description )
                     STRFREE( obj->description );
                  if( obj->short_descr )
                     STRFREE( obj->short_descr );
                  DISPOSE( obj );
                  return;
               }


Replace with:
               if( !fNest || !fVnum )
               {
                  if( obj->name )
                     bug( "%s: %s incomplete object.", __FUNCTION__, obj->name );
                  else
                     bug( "%s: incomplete object.", __FUNCTION__ );
                  free_obj( obj );
                  return;
               }


mud.h
Locate:
/* handler.c */

Below that, add:
void free_obj( OBJ_DATA * obj );


The leak occurs because the code here in fread_obj only undoes the 3 strings, but an incomplete object may have much more data than this when DISPOSEd of and so calling free_obj ensures that all of the data is properly removed. This should only represent a problem if you have a bunch of incomplete objects laying about in your pfiles, but there's no sense in leaving the door open for leaks.

Pages:<< prev 1 next >>