Login
User Name:

Password:



Register

Forgot your password?
 void nanny_get_new_race -- comm.c
Mar 13, 2025 7:08 am
By Elwood
IPv6
Jan 25, 2025 10:45 pm
By Samson
mudstrlcpy and mudstrlcat
Jan 18, 2025 5:23 pm
By Samson
I3 and IMC
Jan 17, 2025 9:35 pm
By Samson
AFKMud 2.5.1
Jan 17, 2025 2:22 pm
By Samson
SmaugFUSS 1.9.7
Author: Various
Submitted by: Samson
AFKMud 2.5.1
Author: AFKMud Team
Submitted by: Samson
Kayle's Weather Code for AFKMud
Author: Kayle
Submitted by: Samson
AFKMud 2.5.0
Author: AFKMud Team
Submitted by: Samson
SWFotEFUSS 1.5.2
Author: Various
Submitted by: Samson
Users Online
Anthropic, AhrefsBot, Bing, Meta

Members: 0
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
503
3,812
19,720
594
BiancaLowr

» SmaugMuds » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Memory Leaks in fread_p...
Forum Rules | Mark all | Recent Posts

[Bug] Memory Leaks in fread_planet.
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 4, 2010 5:10 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
Bug: Memory Leaks while reading GovernedBy and Starsystem of planets.
Danger: High - Memory Leaks are BAD.
Found by: Caius
Fixed by: Kayle and Caius

---

clans.c, fread_planet

Find:
         case 'G':
            if( !str_cmp( word, "GovernedBy" ) )
            {
               planet->governed_by = get_clan( fread_string( fp ) );
               fMatch = TRUE;
            }
            break;


Replace with:
         case 'G':
            if( !str_cmp( word, "GovernedBy" ) )
            {
               const char *clan_name = fread_string( fp );
               planet->governed_by = get_clan( clan_name );
               fMatch = TRUE;
               STRFREE( clan_name );
            }
            break;



Find:
            if( !str_cmp( word, "Starsystem" ) )
            {
               planet->starsystem = starsystem_from_name( fread_string( fp ) );
               if( planet->starsystem )
               {
                  SPACE_DATA *starsystem = planet->starsystem;

                  LINK( planet, starsystem->first_planet, starsystem->last_planet, next_in_system, prev_in_system );
               }
               fMatch = TRUE;
            }


Replace with:
            if( !str_cmp( word, "Starsystem" ) )
            {
               const char *starsystem_name = fread_string( fp );
               planet->starsystem = starsystem_from_name( starsystem_name );
               if( planet->starsystem )
               {
                  SPACE_DATA *starsystem = planet->starsystem;

                  LINK( planet, starsystem->first_planet, starsystem->last_planet, next_in_system, prev_in_system );
               }
               fMatch = TRUE;
               STRFREE( starsystem_name );
            }


I think I said this already, but.. Memory Leaks are BAD. Bad for business. Bad for.. just Bad. See, fread_string calls STRALLOC. Which allocates memory. But said memory was never being freed. Thus.. memory leak. So you do what I did and poof. No more leak.
(I wrote up this fix at like 3AM. This is a prime example of why working while tired is a bad thing...)

Pages:<< prev 1 next >>