Login
User Name:

Password:



Register

Forgot your password?
IPv6
Jan 20, 2025 12:38 pm
By GatewaySysop
mudstrlcpy and mudstrlcat
Jan 18, 2025 5:23 pm
By Samson
I3 and IMC
Jan 17, 2025 9:35 pm
By Samson
AFKMud 2.5.1
Jan 17, 2025 2:22 pm
By Samson
Array out of bounds ?
Jan 16, 2025 4:48 am
By Remcon
SmaugFUSS 1.9.7
Author: Various
Submitted by: Samson
AFKMud 2.5.1
Author: AFKMud Team
Submitted by: Samson
Kayle's Weather Code for AFKMud
Author: Kayle
Submitted by: Samson
AFKMud 2.5.0
Author: AFKMud Team
Submitted by: Samson
SWFotEFUSS 1.5.2
Author: Various
Submitted by: Samson
Users Online
CommonCrawl, Meta, Bing, Bytespider

Members: 0
Guests: 17
Stats
Files
Topics
Posts
Members
Newest Member
503
3,811
19,713
594
FranklynWo

» SmaugMuds » Codebases » SmaugFUSS » Bug: move_char( )
Forum Rules | Mark all | Recent Posts

Bug: move_char( )
< Newer Topic :: Older Topic > Not quite right...

Pages:<< prev 1 next >>
Post is unread #1 Aug 30, 2024 3:52 am   
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts428
JoinedMar 7, 2005

 

In act_move.c, function move_char( ), locate this section:

	    if ( (ch->mount && !IS_FLOATING(ch->mount)) || !IS_FLOATING(ch) )
	    {
		/*
		 * Look for a boat.
		 * We can use the boat obj for a more detailed description.
		 */


Suppose ch has a flying/floating mount, but ch themselves are not flying/floating. If so, why the hell would you still be checking for a boat? That's kinda... not right. There's also no accounting for being able to breath water.

That should probably read more like this:

	    if ( ( !ch->mount && !IS_FLOATING( ch ) && !IS_AFFECTED( ch, AFF_AQUA_BREATH ) )  
	      || ( ch->mount && !IS_FLOATING( ch->mount ) && !IS_AFFECTED( ch->mount, AFF_AQUA_BREATH ) ) )
	    {
    		/*
    		 * Look for a boat.
    		 * We can use the boat obj for a more detailed description.
    		 */

Pages:<< prev 1 next >>