Login
User Name:

Password:



Register

Forgot your password?
 Smaug muds with a Player Base
Jan 15, 2025 3:23 am
By EthanFinn
 Array out of bounds ?
Jan 14, 2025 10:00 pm
By Samson
 AFKMud 2.5.0
Jan 14, 2025 3:27 pm
By Samson
time_update
Jan 12, 2025 9:53 pm
By Remcon
pwd memory leak
Jan 11, 2025 6:31 pm
By Samson
AFKMud 2.5.0
Author: AFKMud Team
Submitted by: Samson
SWFotEFUSS 1.5.2
Author: Various
Submitted by: Samson
SWRFUSS 1.4.2
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.6
Author: Various
Submitted by: Samson
AFKMud 2.2.5
Author: AFKMud Team
Submitted by: Samson
Users Online
Anthropic, AhrefsBot, DotBot, Bing, Bytespider

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
500
3,824
19,774
591
EthanFinn

» SmaugMuds » Codebases » SmaugFUSS » Bug: move_char( )
Forum Rules | Mark all | Recent Posts

Bug: move_char( )
< Newer Topic :: Older Topic > Not quite right...

Pages:<< prev 1 next >>
Post is unread #1 Aug 30, 2024 3:52 am   
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts424
JoinedMar 7, 2005

 

In act_move.c, function move_char( ), locate this section:

	    if ( (ch->mount && !IS_FLOATING(ch->mount)) || !IS_FLOATING(ch) )
	    {
		/*
		 * Look for a boat.
		 * We can use the boat obj for a more detailed description.
		 */


Suppose ch has a flying/floating mount, but ch themselves are not flying/floating. If so, why the hell would you still be checking for a boat? That's kinda... not right. There's also no accounting for being able to breath water.

That should probably read more like this:

	    if ( ( !ch->mount && !IS_FLOATING( ch ) && !IS_AFFECTED( ch, AFF_AQUA_BREATH ) )  
	      || ( ch->mount && !IS_FLOATING( ch->mount ) && !IS_AFFECTED( ch->mount, AFF_AQUA_BREATH ) ) )
	    {
    		/*
    		 * Look for a boat.
    		 * We can use the boat obj for a more detailed description.
    		 */

Pages:<< prev 1 next >>