Bug: Players who idle off at certain login screens can duplicate pets
Danger: High - Game exploit. This will give anyone with a pet a distinctly unfair advantage over those who don't.
Discovered in: AFKMud 2.02
Found by: Zeno
Fixed by: Remcon

---

character.cpp, char_data::~char_data()

Locate:

   list::iterator pd;
   for( pd = mpact.begin(); pd != mpact.end(); )
   {
      mprog_act_list *actp = (*pd);
      ++pd;

      deleteptr( actp );
   }

Below that, add:

   list::iterator ich;
   for( ich = this->pets.begin(); ich != this->pets.end(); )
   {
      char_data *mob = *ich;
      ++ich;

      mob->extract( true );
      deleteptr( mob );
   }

Apparently when someone who has a pet logs in and idles off at the "press enter" prompt, or any other similarly constructed login prompt, and then idles out they can duplicate their saved pets. Since pets load along with the rest of the character data, this can eventually lead to several copies sitting at the spot where the player last left the game. Not only does this create a major game exploit, it can also lead to resource waste as more and more copies of the mob get loaded.