Login
User Name:

Password:



Register

Forgot your password?
Forum Search/User Post History
May 13, 2019 12:43 pm
By Keirath
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018 7:31 pm
By joeyfogas
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl

Members: 0
Guests: 0
Stats
Files
Topics
Posts
Members
Newest Member
482
3,746
19,403
574
Throckrod

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » AFKMud Bugfix List » [Bug] Somewhere exits are not...
Forum Rules | Mark all | Recent Posts

[Bug] Somewhere exits are not always handled right by get_dir
< Newer Topic :: Older Topic > AFKMud 2.03

Pages:<< prev 1 next >>
Post is unread #1 Feb 21, 2008 11:41 pm   
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,653
JoinedJan 1, 2002

 
Bug: Somewhere exits are not always handled right by get_dir
Danger: Low - This requires a very specific usage of the redit command before the issue shows itself.
Discovered in: AFKMud 2.03
Found by: Remcon
Fixed by: Remcon

---

build.cpp, get_dir

Locate:
      case 'e':
      case '1':
         edir = DIR_EAST;
         break;   /* east  */


Change to:
      case 'e':
      case '1':
         if( c2 == '0' )
            edir = DIR_SOMEWHERE;
         else
            edir = DIR_EAST;
         break;   /* east  */


In a very specific set of circumstances, the redit command can return an incorrect direction when trying to add a somewhere exit. This is due to how the switch statement in get_dir is setup. It uses the first character of the input value for the case checks. 'e' and '1' correspond to the same thing - East. But a somewhere exit can be entered as '?' or '10' which creates a problem. The case '1' needs to look to see if c2 is '0' and if it is, set edir to DIR_SOMEWHERE instead since that's what the command actually intended.

There is also a secondary issue with this function that's not easily fixed. If the direction numbers themselves have been reassigned, this function would produce bad results for anything called by the numerical value. This function would need to get redone along with any reassignment of the values.

Pages:<< prev 1 next >>