Login
User Name:

Password:



Register

Forgot your password?
Dusting off the old code...
Jul 15, 2019 10:53 pm
By InfiniteAxis
Forum Search/User Post History
May 13, 2019 12:43 pm
By Keirath
AFKMud 2.2.2
Mar 3, 2019 5:35 pm
By Samson
Development
Nov 28, 2018 12:10 pm
By Keirath
First Immortal
Oct 12, 2018 2:02 pm
By GatewaySysop
SmaugFUSS 1.9.3
Author: Various
Submitted by: Samson
AFKMud 2.2.2
Author: AFKMud Team
Submitted by: Samson
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl

Members: 0
Guests: 0
Stats
Files
Topics
Posts
Members
Newest Member
482
3,748
19,405
583
Monserrate

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » AFKMud Bugfix List » [Bug] Substate commands do no...
Forum Rules | Mark all | Recent Posts

[Bug] Substate commands do not work
< Newer Topic :: Older Topic > AFKMud 2.1.1

Pages:<< prev 1 next >>
Post is unread #1 May 22, 2009 12:01 am   
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,653
JoinedJan 1, 2002

 
Bug: Substate commands do not work
Danger: High - Blocks all attempts at user input once the substate is locked.
Discovered in: AFKMud 2.1.1
Found by: tphegley
Fixed by: Samson

---

commands.cpp, interpret

Locate:
         /*
          * yes... we lose out on the hashing speediness here...
          * but the only REPEATCMDS are wizcommands (currently)
          */
         for( char x = 0; x < 126; ++x )
         {
            const vector < cmd_type * >&cmd_list = command_table[x];
            vector < cmd_type * >::const_iterator icmd;

            for( icmd = cmd_list.begin(  ); icmd != cmd_list.end(  ); ++icmd )
            {
               cmd = *icmd;

               if( cmd->do_fun != fun )
                  continue;
               found = true;
               break;
            }
         }


Change to:
         /*
          * yes... we lose out on the hashing speediness here...
          * but the only REPEATCMDS are wizcommands (currently)
          */
         for( char x = 0; x < 126; ++x )
         {
            const vector < cmd_type * >&cmd_list = command_table[x];
            vector < cmd_type * >::const_iterator icmd;

            for( icmd = cmd_list.begin(  ); icmd != cmd_list.end(  ); ++icmd )
            {
               cmd = *icmd;

               if( cmd->do_fun != fun )
                  continue;
               found = true;
               break;
            }
            if( found )
               break;
         }


The missing ifcheck at the bottom of the for loop is necessary to break it out of the command search when one is found. Otherwise it never breaks out and lands on whatever the last command in the list is, in this case always ending on the "zones" command. This only affected commands issued from substates such as "redit on" and once in the substate no commands issued would work until either disconnecting and waiting for a sufficient time period or forcing the MUD to reboot somehow.

Pages:<< prev 1 next >>