Bug: Substate commands do not work
Danger: High - Blocks all attempts at user input once the substate is locked.
Discovered in: AFKMud 2.1.1
Found by: tphegley
Fixed by: Samson

---

commands.cpp, interpret

Locate:

         /*
          * yes... we lose out on the hashing speediness here...
          * but the only REPEATCMDS are wizcommands (currently)
          */
         for( char x = 0; x < 126; ++x )
         {
            const vector < cmd_type * >&cmd_list = command_table[x];
            vector < cmd_type * >::const_iterator icmd;

            for( icmd = cmd_list.begin(  ); icmd != cmd_list.end(  ); ++icmd )
            {
               cmd = *icmd;

               if( cmd->do_fun != fun )
                  continue;
               found = true;
               break;
            }
         }

Change to:

         /*
          * yes... we lose out on the hashing speediness here...
          * but the only REPEATCMDS are wizcommands (currently)
          */
         for( char x = 0; x < 126; ++x )
         {
            const vector < cmd_type * >&cmd_list = command_table[x];
            vector < cmd_type * >::const_iterator icmd;

            for( icmd = cmd_list.begin(  ); icmd != cmd_list.end(  ); ++icmd )
            {
               cmd = *icmd;

               if( cmd->do_fun != fun )
                  continue;
               found = true;
               break;
            }
            if( found )
               break;
         }

The missing ifcheck at the bottom of the for loop is necessary to break it out of the command search when one is found. Otherwise it never breaks out and lands on whatever the last command in the list is, in this case always ending on the "zones" command. This only affected commands issued from substates such as "redit on" and once in the substate no commands issued would work until either disconnecting and waiting for a sufficient time period or forcing the MUD to reboot somehow.