[Bug] The destroy_immdata function has buffer overflows.
< Newer Topic
:: Older Topic >
AFKMud 2.1.2
Pages:<< prev 1 next >>
#1 Mar 8, 2010 12:34 am
Last edited Mar 8, 2010 12:34 am by Samson
Black Hand
GroupAdministrators
Posts3,697
JoinedJan 1, 2002
Bug: The destroy_immdata function has buffer overflows.
Danger: High - Very likely deleting an immortal from the game will result in a crash due to overflowed buffers.
Discovered in: AFKMud 2.1.2 (delayed posting - already fixed in 2.1.3)
Found by: apocalypticNRG
Fixed by: Samson
---
act_wiz.cpp, destroy_immdata
Locate:
Change to:
Well, that's embarrassing. these buffers were trying to stuff MSL length data into a space 256 bytes long. What more needs to be said?
Danger: High - Very likely deleting an immortal from the game will result in a crash due to overflowed buffers.
Discovered in: AFKMud 2.1.2 (delayed posting - already fixed in 2.1.3)
Found by: apocalypticNRG
Fixed by: Samson
---
act_wiz.cpp, destroy_immdata
Locate:
char buf[256], buf2[256];
Change to:
char buf[MSL], buf2[MSL];
Well, that's embarrassing. these buffers were trying to stuff MSL length data into a space 256 bytes long. What more needs to be said?
Pages:<< prev 1 next >>