Login
User Name:

Password:



Register

Forgot your password?
Changes list / Addchange
Author: Khonsu
Submitted by: Khonsu
6Dragons mp3 sound pack
Author: Vladaar
Submitted by: Vladaar
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
Users Online
Naver, Google

Members: 0
Guests: 28
Stats
Files
Topics
Posts
Members
Newest Member
488
3,788
19,631
595
Khonsu

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Bugfix Lists » AFKMud Bugfix List » [Bug] The destroy_immdata fun...
Forum Rules | Mark all | Recent Posts

[Bug] The destroy_immdata function has buffer overflows.
< Newer Topic :: Older Topic > AFKMud 2.1.2

Pages:<< prev 1 next >>
Post is unread #1 Mar 8, 2010 12:34 am   Last edited Mar 8, 2010 12:34 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,685
JoinedJan 1, 2002

 
Bug: The destroy_immdata function has buffer overflows.
Danger: High - Very likely deleting an immortal from the game will result in a crash due to overflowed buffers.
Discovered in: AFKMud 2.1.2 (delayed posting - already fixed in 2.1.3)
Found by: apocalypticNRG
Fixed by: Samson

---

act_wiz.cpp, destroy_immdata

Locate:
   char buf[256], buf2[256];


Change to:
   char buf[MSL], buf2[MSL];


Well, that's embarrassing. these buffers were trying to stuff MSL length data into a space 256 bytes long. What more needs to be said?

Pages:<< prev 1 next >>