I'm just curious if anyone has gotten the house snippet to work on SmaugFUSS 1.9?
Its a right pain in my ass, anyone fancy helping with a thorn? ::inno::

What are you having issues with?

The whole thing... I've fixed a few things, but there is so many errors its mind boggling.
Basically, the housing snippet was designed for 1.4a and because 1.9 SmaugFUSS is been changed so much, its resets etc are so different... plus loads more too...

I'll past the huge buglist I get =P

house.c: In function `void do_house(CHAR_DATA*, char*)':
house.c:50: error: invalid conversion from `void*' to `ROOM_INDEX_DATA*'
house.c:53: warning: too many arguments for format
house.c:247: warning: declaration of `i' shadows a previous local
house.c:40: warning: shadowed declaration is here
house.c: In function `void do_gohome(CHAR_DATA*, char*)':
house.c:484: error: no match for 'operator&' in '
   ch->char_data::in_room->room_index_data::room_flags & ROOM_NO_RECALL'
house.c: In function `void do_accessories(CHAR_DATA*, char*)':
house.c:850: error: syntax error before numeric constant
house.c:924: error: cannot convert `AREA_DATA*' to `ROOM_INDEX_DATA*' for
   argument `1' to `RESET_DATA* add_reset(ROOM_INDEX_DATA*, char, int, int,
   int, int)'
house.c: In function `void save_residence(ROOM_INDEX_DATA*)':
house.c:1444: warning: too many arguments for format
house.c:1467: warning: too many arguments for format
house.c: In function `bool set_house(CHAR_DATA*, int, bool)':
house.c:1532: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_NO_SUMMON'
house.c:1533: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_NO_ASTRAL'
house.c:1534: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_INDOORS'
house.c:1535: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_SAFE'
house.c: In function `bool remove_house(CHAR_DATA*)':
house.c:1661: error: 'struct area_data' has no member named 'first_reset'
house.c:1718: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -21'
house.c:1719: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -22'
house.c:1720: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -4'
house.c:1721: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -11'
house.c:1753: error: 'struct area_data' has no member named 'first_reset'
mud.h: In function `bool add_room(HOME_DATA*, ROOM_INDEX_DATA*, char*)':
mud.h:4563: error: too few arguments to function `ROOM_INDEX_DATA*
   make_room(int, AREA_DATA*)'
house.c:1794: error: at this point in file
house.c:1837: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_NO_SUMMON'
house.c:1838: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_NO_ASTRAL'
house.c:1839: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_INDOORS'
house.c:1840: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_SAFE'
house.c:1841: error: no match for 'operator&=' in '
   addloc->room_index_data::room_flags &= -31'
house.c: In function `void fwrite_house(HOME_DATA*)':
house.c:1890: warning: too many arguments for format
mud.h:4894: error: too few arguments to function `void fwrite_obj(CHAR_DATA*,
   OBJ_DATA*, FILE*, int, short int, bool)'
house.c:1925: error: at this point in file
house.c: In function `void load_homedata()':
house.c:1946: error: `fpReserve' undeclared (first use this function)
house.c:1946: error: (Each undeclared identifier is reported only once for each
   function it appears in.)
house.c:1957: error: invalid conversion from `const char*' to `char*'
house.c:1972: error: `NULL_FILE' undeclared (first use this function)
house.c: In function `void update_house_list()':
house.c:2069: warning: too many arguments for format
house.c: In function `int fread_house(FILE*)':
house.c:2106: error: invalid conversion from `const char*' to `char*'
house.c:2122: warning: too many arguments for format
house.c: In function `void save_accessories()':
house.c:2179: warning: too many arguments for format
house.c: In function `void load_accessories()':
house.c:2215: warning: too many arguments for format
house.c:2234: warning: too many arguments for format
house.c:2249: warning: too many arguments for format
house.c: In function `void fread_accessories(FILE*)':
house.c:2282: error: invalid conversion from `const char*' to `char*'
house.c:2299: warning: too many arguments for format
house.c: In function `void save_homebuy()':
house.c:2411: warning: too many arguments for format
house.c: In function `void load_homebuy()':
house.c:2451: warning: too many arguments for format
house.c:2470: warning: too many arguments for format
house.c:2490: warning: too many arguments for format
house.c: In function `void fread_homebuy(FILE*)':
house.c:2523: error: invalid conversion from `const char*' to `char*'
house.c:2552: warning: too many arguments for format
house.c: In function `CHAR_DATA* load_player(char*)':
house.c:2963: error: `check_parse_name' undeclared (first use this function)
mud.h:4891: error: too few arguments to function `bool
   load_char_obj(DESCRIPTOR_DATA*, char*, bool, bool)'
house.c:2975: error: at this point in file
house.c: In function `void fread_loginmsg(FILE*)':
house.c:3068: error: invalid conversion from `const char*' to `char*'
house.c:3085: warning: too many arguments for format
house.c:3188:2: no newline at end of file
make[1]: *** [o/house.o] Error 1
make: *** [all] Error 2

Ah, it looks like part of the reason is that it uses resets and the new reset system is different. I'm not sure how the new reset code works offhand, so examine the new code and see how it should be replaced in the housing code.

Yeh, I think I been pointed to an old topic about the reset... going to give these a try. Let you know how it goes Zeno, cheers.

http://smaugmuds.afkmods.com/index.php?a=topic&t=1539

Here is what I get with the whole reset changes. Didn't have much difference... guessing no one has a clean'd version for 1.9? lying around? lol..

house.c: In function `void do_house(CHAR_DATA*, char*)':
house.c:50: error: invalid conversion from `void*' to `ROOM_INDEX_DATA*'
house.c:53: warning: too many arguments for format
house.c:247: warning: declaration of `i' shadows a previous local
house.c:40: warning: shadowed declaration is here
house.c: In function `void do_gohome(CHAR_DATA*, char*)':
house.c:484: error: no match for 'operator&' in '
   ch->char_data::in_room->room_index_data::room_flags & ROOM_NO_RECALL'
house.c: In function `void do_accessories(CHAR_DATA*, char*)':
house.c:850: error: syntax error before numeric constant
house.c: In function `void save_residence(ROOM_INDEX_DATA*)':
house.c:1445: warning: too many arguments for format
house.c:1468: warning: too many arguments for format
house.c: In function `bool set_house(CHAR_DATA*, int, bool)':
house.c:1533: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_NO_SUMMON'
house.c:1534: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_NO_ASTRAL'
house.c:1535: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_INDOORS'
house.c:1536: error: no match for 'operator|=' in '
   location->room_index_data::room_flags |= ROOM_SAFE'
house.c: In function `bool remove_house(CHAR_DATA*)':
house.c:1679: error: `delete_reset' undeclared (first use this function)
house.c:1679: error: (Each undeclared identifier is reported only once for each
   function it appears in.)
house.c:1729: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -21'
house.c:1730: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -22'
house.c:1731: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -4'
house.c:1732: error: no match for 'operator&=' in '
   location->room_index_data::room_flags &= -11'
mud.h: In function `bool add_room(HOME_DATA*, ROOM_INDEX_DATA*, char*)':
mud.h:4563: error: too few arguments to function `ROOM_INDEX_DATA*
   make_room(int, AREA_DATA*)'
house.c:1814: error: at this point in file
house.c:1857: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_NO_SUMMON'
house.c:1858: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_NO_ASTRAL'
house.c:1859: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_INDOORS'
house.c:1860: error: no match for 'operator|=' in '
   addloc->room_index_data::room_flags |= ROOM_SAFE'
house.c:1861: error: no match for 'operator&=' in '
   addloc->room_index_data::room_flags &= -31'
house.c: In function `void fwrite_house(HOME_DATA*)':
house.c:1910: warning: too many arguments for format
mud.h:4894: error: too few arguments to function `void fwrite_obj(CHAR_DATA*,
   OBJ_DATA*, FILE*, int, short int, bool)'
house.c:1945: error: at this point in file
house.c: In function `void load_homedata()':
house.c:1966: error: `fpReserve' undeclared (first use this function)
house.c:1977: error: invalid conversion from `const char*' to `char*'
house.c:1992: error: `NULL_FILE' undeclared (first use this function)
house.c: In function `void update_house_list()':
house.c:2089: warning: too many arguments for format
house.c: In function `int fread_house(FILE*)':
house.c:2126: error: invalid conversion from `const char*' to `char*'
house.c:2142: warning: too many arguments for format
house.c: In function `void save_accessories()':
house.c:2199: warning: too many arguments for format
house.c: In function `void load_accessories()':
house.c:2235: warning: too many arguments for format
house.c:2254: warning: too many arguments for format
house.c:2269: warning: too many arguments for format
house.c: In function `void fread_accessories(FILE*)':
house.c:2302: error: invalid conversion from `const char*' to `char*'
house.c:2319: warning: too many arguments for format
house.c: In function `void save_homebuy()':
house.c:2431: warning: too many arguments for format
house.c: In function `void load_homebuy()':
house.c:2471: warning: too many arguments for format
house.c:2490: warning: too many arguments for format
house.c:2510: warning: too many arguments for format
house.c: In function `void fread_homebuy(FILE*)':
house.c:2543: error: invalid conversion from `const char*' to `char*'
house.c:2572: warning: too many arguments for format
house.c: In function `CHAR_DATA* load_player(char*)':
house.c:2983: error: `check_parse_name' undeclared (first use this function)
mud.h:4891: error: too few arguments to function `bool
   load_char_obj(DESCRIPTOR_DATA*, char*, bool, bool)'
house.c:2995: error: at this point in file
house.c: In function `void fread_loginmsg(FILE*)':
house.c:3088: error: invalid conversion from `const char*' to `char*'
house.c:3105: warning: too many arguments for format
house.c:3208:2: no newline at end of file
make[1]: *** [o/house.o] Error 1
make: *** [all] Error 2

Which version of the housing snippet are you using?

A real old one... one for 1.4a Smaug I believe. Thats why im wondering if anyone has a more up todate version of it? One possible that is a little less buggy for SmaugFUSS? heh.

http://www.mudbytes.net/index.php?a=files&s=viewfile&fid=2399

That snippet needs to have support for the new reset system added, in addition to being fixed for proper const char* usage. This particular snippet also had some bugs in it but information about what they were has been lost since the author's original site is gone.

Should be renamed to Senir's Bug Housing Snippet. Last time I looked at this snippet I was ashamed I'd even considered using it. =/

I know... but it looks so attractive...
Hmmm, does anyone know if these ones who have got it working on SmaugFUSS 1.6 would work for 1.9? Kinda just need to find a nice person who has it working for 1.6 to send the snippet, so it can be updated instead of it being so terrible.

Well if someone got it working with SmaugFUSS 1.6, we've got no objection to it being uploaded here. I'm also pretty sure the snippet on MudBytes could stand to be updated with a working version as well. Reset stuff for 1.6 should work with 1.9. I don't really remember if anything changed enough between versions to matter for what the housing code does.

I got it working on my mud with smaugfuss resetfix. I think Remcon helped me with it. I don't mind posting the 2 files or just emailing them to you if you want. I don't even use housing code yet, cause I want to customize
it to be medieval instead of how it is currently.

Vladaar

If there's a big enough call for it, I can grab the snippet from MudBytes, plug it into a stock FUSS 1.9 and clean it up and release a fixed version of the snippet. But I'm not going to do it if just one person wants it, especially with simple errors like you have reporting.

A large chunk of those errors appears to be improper bit use. Likely trying to use Bitvector macros on an Extended bitvector field. A lot of them are too many arguments or too few arguments which means you need to check the FUSS 1.9 defines and make the calls match the prototypes for the functions being used.

house.c:1718: error: no match for 'operator&=' in '
location->room_index_data::room_flags &= -21'
house.c:1719: error: no match for 'operator&=' in '
location->room_index_data::room_flags &= -22'
house.c:1720: error: no match for 'operator&=' in '
location->room_index_data::room_flags &= -4'
house.c:1721: error: no match for 'operator&=' in '
location->room_index_data::room_flags &= -11'

These are all bitwise errors, check to see whether room_flags is defined as int or EXT_BV. If it's an int make sure the calls are using IS_SET etc. If it's EXT_BV make sure the calls use xIS_SET etc.

house.c:2106: error: invalid conversion from `const char*' to `char*'
house.c:2122: warning: too many arguments for format
house.c: In function `void save_accessories()':
house.c:2179: warning: too many arguments for format
house.c: In function `void load_accessories()':
house.c:2215: warning: too many arguments for format
house.c:2234: warning: too many arguments for format
house.c:2249: warning: too many arguments for format

These are likely bug statements with a , 0 ); on the end or something inane like that.

house.c:1946: error: `fpReserve' undeclared (first use this function)
house.c:1946: error: (Each undeclared identifier is reported only once for each
function it appears in.)

Did Smaug ever use the fpReserve deal? I don't ever remember using it. Find a function that does somthing similar to what he's attempting to do here, and emulate it.

house.c:1957: error: invalid conversion from `const char*' to `char*'

This is a string thing. You're passing something as a char * into a function expecting a const char*. Or whatever you've declared as a char* should be a const char*. GCC has decided we all need to be forced to learn proper constness. Get used to these, you'll see them a lot while installing old snippets in FUSS 1.9.

house.c:1972: error: `NULL_FILE' undeclared (first use this function)

You got me here. I've never seen this before.

fpReserve and the NULL_FILE thing can both be removed. FUSS hasn't had either one of those in ages since they've not been necessary for at least 10 years now.

The bitwise stuff is indeed from changing rooms to use EXT_BV at some point.

If Vlad's copy has more of this fixed I see no reason not to grab what he's got and fill in the rest.

http://6dragons.org/house.c
http://6dragons.org/house.h

6dragons think you can reupload those files?

Did anyone else get the house code to work with the new reset system? and would be willing to upload it I tried to and can't get it to work right.

Well mind telling me what house code you have and where to find it? lol can't update what I can't find lol.

Umm it's the same one posted at the beginning of this thread