So, do_hset uses smash_tilde_copy.

smash_tilde_copy uses strdup and returns a pointer to this duplicate string.

do_hset doesn't free this string.

Isn't this a memory leak?

great find, feel free to fix it and post a fix for everyone, if you would like to

This may be arbitrary as both solutions are "equal" (haven't tested them though). But as far as style or standards goes, which would you consider more conformant?

free(argument);

or

argument = smash_tilde(argument);

Assuming that this is a standard across all codebases:

const char * smash_tilde(const char *);

I'm compiling on g++ and most of my char * argument's have been turned into const char *.