Login
User Name:

Password:



Register

Forgot your password?
6Dragons mp3 sound pack
Author: Vladaar
Submitted by: Vladaar
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
SWRFUSS 1.4
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.4
Author: Various
Submitted by: Samson
Users Online
AhrefsBot, Voldemar

Members: 1
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
487
3,788
19,630
595
Salan

Today's Birthdays
Gatz (39)
» SmaugMuds » Codebases » SWFOTE FUSS » Memory leak with do_hset and ...
Forum Rules | Mark all | Recent Posts

Memory leak with do_hset and smash_tilde_copy?
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 5, 2016 1:43 am   
Go to the top of the page
Go to the bottom of the page

Kasji
Apprentice
GroupMembers
Posts63
JoinedDec 23, 2007

 
So, do_hset uses smash_tilde_copy.

smash_tilde_copy uses strdup and returns a pointer to this duplicate string.

do_hset doesn't free this string.

Isn't this a memory leak?

Post is unread #2 Sep 5, 2016 11:10 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,913
JoinedJul 26, 2005

 
great find, feel free to fix it and post a fix for everyone, if you would like to :)

Post is unread #3 Sep 7, 2016 6:29 pm   Last edited Sep 7, 2016 6:36 pm by Kasji
Go to the top of the page
Go to the bottom of the page

Kasji
Apprentice
GroupMembers
Posts63
JoinedDec 23, 2007

 
This may be arbitrary as both solutions are "equal" (haven't tested them though). But as far as style or standards goes, which would you consider more conformant?

free(argument);


or

argument = smash_tilde(argument);


Assuming that this is a standard across all codebases:

const char * smash_tilde(const char *);


I'm compiling on g++ and most of my char * argument's have been turned into const char *.

Pages:<< prev 1 next >>