
Pages:<< prev 1 next >>


Apprentice

GroupMembers
Posts86
JoinedAug 25, 2003
Hi, I downloaded for a comparison I think the last smaugfuss and I accidentally dropped my eye on the fread_comment.
I admit that I have not tried to compile and check on 1.94 but in my opinion this part of the code lacks what I added in red otherwise I do not see how the double linked list can form
Otherwise the list will be produced but the recursive element will be missing and when you go to use the remove_comment it will delete half the list according to the note you are going to remove. I belive... BYE!
I admit that I have not tried to compile and check on 1.94 but in my opinion this part of the code lacks what I added in red otherwise I do not see how the double linked list can form
if( str_cmp( fread_word( fp ), "text" ) )
break;
pnote->text = fread_string( fp );
pnote->next = ch->comments;
/*
* Fixed a big bug here - Luc 08/2000
*/
if( pnote->next )
pnote->next->prev = pnote;
pnote->prev = NULL;
ch->comments = pnote;
return;
Otherwise the list will be produced but the recursive element will be missing and when you go to use the remove_comment it will delete half the list according to the note you are going to remove. I belive... BYE!



Conjurer

GroupMembers
Posts429
JoinedMar 7, 2005
Interestingly enough, my very dated derivative of Smaug 1.4a FUSS seems to have this already. I don't recall every making the change, so perhaps it got taken out somewhere along the lines?
Pages:<< prev 1 next >>