Login
User Name:

Password:



Register

Forgot your password?
void nanny_get_new_race -- comm.c
Mar 13, 2025 7:08 am
By Elwood
IPv6
Jan 25, 2025 10:45 pm
By Samson
mudstrlcpy and mudstrlcat
Jan 18, 2025 5:23 pm
By Samson
I3 and IMC
Jan 17, 2025 9:35 pm
By Samson
AFKMud 2.5.1
Jan 17, 2025 2:22 pm
By Samson
SWFotEFUSS 1.5.3
Author: Various
Submitted by: Samson
SWRFUSS 1.4.3
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.8
Author: Various
Submitted by: Samson
AFKMud 2.5.2
Author: AFKMud Team
Submitted by: Samson
SmaugFUSS 1.9.7
Author: Various
Submitted by: Samson
Users Online
Anthropic, AhrefsBot, Google, Amazonbot, Bytespider

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
507
3,812
19,722
591
TracySpencer

» SmaugMuds » Bugfix Lists » LoP Bugfix List » Sset issue
Forum Rules | Mark all | Recent Posts

Sset issue
< Newer Topic :: Older Topic > Crashing and memory problem

Pages:<< prev 1 next >>
Post is unread #1 Feb 13, 2009 7:35 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,992
JoinedJul 26, 2005

 
in skills.c function do_sset
find
         CREATE( aff, SMAUG_AFF, 1 );
         if( !str_cmp( duration, "0" ) )
            duration[0] = '\0';
         if( !str_cmp( modifier, "0" ) )
            modifier[0] = '\0';
         if( ( loc % REVERSE_APPLY ) == APPLY_EXT_AFFECT )
         {
            int modval = get_flag( modifier, a_flags, AFF_MAX );

            if( modval < 0 || modval >= AFF_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown affect: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         else if( ( loc % REVERSE_APPLY ) == APPLY_RESISTANT
         || ( loc % REVERSE_APPLY ) == APPLY_IMMUNE
         || ( loc % REVERSE_APPLY ) == APPLY_SUSCEPTIBLE
         || ( loc % REVERSE_APPLY ) == APPLY_ABSORB )
         {
            int modval = get_flag( modifier, ris_flags, RIS_MAX );

            if( modval < 0 || modval >= RIS_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown resistant/immune/susceptible/absorb: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         if( ( loc % REVERSE_APPLY ) >= APPLY_STRIPSN && ( loc % REVERSE_APPLY ) < APPLY_STAT )
            if( duration == NULL || duration[0] == '\0' )
               snprintf( duration, sizeof( duration ), "%d", 0 );
         aff->duration = STRALLOC( duration );

change it to
         if( !str_cmp( duration, "0" ) )
            duration[0] = '\0';
         if( !str_cmp( modifier, "0" ) )
            modifier[0] = '\0';
         if( ( loc % REVERSE_APPLY ) == APPLY_EXT_AFFECT )
         {
            int modval = get_flag( modifier, a_flags, AFF_MAX );

            if( modval < 0 || modval >= AFF_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown affect: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         else if( ( loc % REVERSE_APPLY ) == APPLY_RESISTANT
         || ( loc % REVERSE_APPLY ) == APPLY_IMMUNE
         || ( loc % REVERSE_APPLY ) == APPLY_SUSCEPTIBLE
         || ( loc % REVERSE_APPLY ) == APPLY_ABSORB )
         {
            int modval = get_flag( modifier, ris_flags, RIS_MAX );

            if( modval < 0 || modval >= RIS_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown resistant/immune/susceptible/absorb: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         if( ( loc % REVERSE_APPLY ) >= APPLY_STRIPSN && ( loc % REVERSE_APPLY ) < APPLY_STAT )
            if( duration == NULL || duration[0] == '\0' )
               snprintf( duration, sizeof( duration ), "%d", 0 );
         if( ( loc % REVERSE_APPLY ) == APPLY_WAITSTATE && ( modifier == NULL || modifier[0] == '\0' ) )
         {
            send_to_char( "You can't affect waitsate by nothing.\r\n", ch );
            return;
         }
         CREATE( aff, SMAUG_AFF, 1 );
         aff->duration = STRALLOC( duration );

It was creating the affects even if returned and never freeing them (could lead to crashes or odd behavior).
If you did like 'sset affect waitstate' it would crash on saving/viewing/using the spell/skill.

Pages:<< prev 1 next >>