Login
User Name:

Password:



Register

Forgot your password?
do_owhere recursive
Author: Khonsu
Submitted by: Khonsu
Changes list / Addchange
Author: Khonsu
Submitted by: Khonsu
6Dragons mp3 sound pack
Author: Vladaar
Submitted by: Vladaar
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
Users Online
AhrefsBot

Members: 0
Guests: 25
Stats
Files
Topics
Posts
Members
Newest Member
489
3,791
19,644
596
Elwood

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Codebases » AFKMud Support & Development » weaponspell display issue wit...
Forum Rules | Mark all | Recent Posts

weaponspell display issue with fireball
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 21, 2012 1:04 pm   
Go to the top of the page
Go to the bottom of the page

Sherm
Fledgling
GroupMembers
Posts33
JoinedDec 20, 2010

 
So i recently added the weaponspell fireball to a weapon and i have seen some weirdness.

Polaris, the polar star's pierce scratches you. [18]
Your slash tears Polaris, the polar star! [60]
A blazing ball of fire envelops the room!A blazing ball of fire envelops the room!Your fireball wounds Polaris, the polar star! [55]
A blazing ball of fire envelops the room!A blazing ball of fire envelops the room!Your fireball wounds Polaris, the polar star! [53]
Your slash tears Polaris, the polar star! [53]

yet energy blast works fine.
Your energy blast wounds Polaris, the polar star! [53]
Your stab tears Polaris, the polar star! [59]
The energy sword blasts into Polaris, the polar star!
Your energy blast wounds Polaris, the polar star! [52]
Your stab tears Polaris, the polar star! [55]
The energy sword blasts into Polaris, the polar star!
Your energy blast wounds Polaris, the polar star! [53]

Was wonder if anyone else has seen this. If so can you help point me in the right direction as to solving the issue.

Thanks.

Sherm

Post is unread #2 Mar 25, 2012 1:12 pm   
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts413
JoinedMar 7, 2005

 
Can you post up the relevant code that's driving this output? Maybe that would help get a better response from those not intimately familiar with AFK. :thinking:

Post is unread #3 Mar 25, 2012 3:38 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,917
JoinedJul 26, 2005

 
Well if I had to guess it would be the color in the fireball one.
The energy blast doesn't use color
Hitchar      The energy sword blasts into $N!~
Hitvict      $n's energy sword rips into your body!~
Hitroom      $N reels as $n's energy sword rips into $M!~
Misschar     The energy sword crackles as it misses $N!~
Missvict     $n's energy sword crackles loudly as it misses you!~
Missroom     $n's energy sword crackles loudly, missing $N!~
Diechar      The energy sword slices through $N in a final deadly blast!~
Dievict      $n's energy sword slices through your body, killing you!~
Dieroom      $n's energy sword cuts $N clean in half!~

Here is the fireball
Hitchar      &RA blazing ball of fire envelops the room!&z~
Hitvict      &RYou are immolated by a ball of flaming doom!&z~
Hitroom      &R$n immolates the area with a magical fireball!&z~
Misschar     &RYour fireball leaves the target smoking, but unharmed.&z~
Missvict     &RYou escape being burned by $n's fireball!&z~
Missroom     &RThe target escapes being burnt by $n's fireball!&z~
Diechar      &RYour fireball reduces $N into a writhing pile of burnt flesh!&z~
Dievict      &RYou are blasted into oblivion by $n's fireball....&z~
Dieroom      &R$n's fireball reduces $N to a smoking pile of burnt flesh!&z~

Try removing the colors and see if that fixes the issue.

Post is unread #4 Mar 26, 2012 11:38 am   
Go to the top of the page
Go to the bottom of the page

Sherm
Fledgling
GroupMembers
Posts33
JoinedDec 20, 2010

 
will try that and let you guys know.

Post is unread #5 Apr 2, 2012 8:54 pm   
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts413
JoinedMar 7, 2005

 

Sherm said:

will try that and let you guys know.




And ... ? :shrug:

Post is unread #6 Apr 3, 2012 9:10 am   Last edited Apr 3, 2012 9:31 am by Sherm
Go to the top of the page
Go to the bottom of the page

Sherm
Fledgling
GroupMembers
Posts33
JoinedDec 20, 2010

 
still getting:
Bugs: [*****] BUG: dam_message: bad dt 1011 from Snoopy in 9371.
You injure Polaris, the polar star! [61]
A blazing ball of fire envelops the room!A blazing ball of fire envelops the room!Your fireball wounds Polaris, the polar star! [53]
Bugs: [*****] BUG: dam_message: bad dt 1011 from Snoopy in 9371.
You injure Polaris, the polar star! [63]
A blazing ball of fire envelops the room!A blazing ball of fire envelops the room!Your fireball wounds Polaris, the polar star! [54]
Bugs: [*****] BUG: dam_message: bad dt 1011 from Snoopy in 9371.
You injure Polaris, the polar star! [61]
A blazing ball of fire envelops the room!A blazing ball of fire envelops the room!Your fireball wounds Polaris, the polar star! [53]

Post is unread #7 Apr 3, 2012 11:53 am   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,917
JoinedJul 26, 2005

 
Ok, if not answered before this evening ill look into it

Post is unread #8 Apr 4, 2012 8:49 pm   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,917
JoinedJul 26, 2005

 

A blazing ball of fire envelops the room!A blazing ball of fire envelops the room!Your fireball wounds Polaris, the polar star! [55]

The first comes from magic.cpp function spell_area_attack, the last two are from fight.cpp dam_message.

In energy blast it doesn't use spell_area_attack so it doesn't get the first one. While it does get the last two in dam_message it contains a $N.

So lets take a look in act_comm.cpp function act_string
   // No $ token in the string, return now with the contents as is.
   if( format.find( '$', 0 ) == string::npos )
      return format;

This would be where the problem is really. See ones that contain a $ later get a new line added to the end where as these don't so change that to this
   // No $ token in the string, return now with the contents as is.
   if( format.find( '$', 0 ) == string::npos )
   {
      buf.append( format );
      buf.append( "\r\n" );
      return buf;
   }

Worked great in the test I did. You don't have to get rid of the first one if you don't want to, or you can its one of those up to you things, but fixing the act_string function will give you the new line that it needs to have between those.

Post is unread #9 Apr 5, 2012 10:18 am   
Go to the top of the page
Go to the bottom of the page

Sherm
Fledgling
GroupMembers
Posts33
JoinedDec 20, 2010

 
Cool I will work on this today and see if it fixes this for me.

Thanks a Ton Remcon.

Post is unread #10 Apr 9, 2012 8:31 am   
Go to the top of the page
Go to the bottom of the page

Sherm
Fledgling
GroupMembers
Posts33
JoinedDec 20, 2010

 
This worked, now i need to track down the bad dt message i get evertime fireball message i get a bug message:

Bugs: [*****] BUG: dam_message: bad dt 1011 from Snoopy in 9371.


I am betting its a issue with that its a area effect spell.

Post is unread #11 Apr 9, 2012 10:50 am   
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,917
JoinedJul 26, 2005

 
Well its getting a bad dt from its damage type. Na I practiced with it during testing never got a bug message. If you use slookup fireball its damage type should be set to fire. It could be the damage type on the weapon is wrong also.

Post is unread #12 Apr 9, 2012 12:10 pm   
Go to the top of the page
Go to the bottom of the page

Sherm
Fledgling
GroupMembers
Posts33
JoinedDec 20, 2010

 
Yeah looking at that right now.

Pages:<< prev 1 next >>