Login
User Name:

Password:



Register

Forgot your password?
do_owhere recursive
Author: Khonsu
Submitted by: Khonsu
Changes list / Addchange
Author: Khonsu
Submitted by: Khonsu
6Dragons mp3 sound pack
Author: Vladaar
Submitted by: Vladaar
AFKMud 2.2.3
Author: AFKMud Team
Submitted by: Samson
SWFOTEFUSS 1.5
Author: Various
Submitted by: Samson
Users Online
Bing, Yandex, AhrefsBot

Members: 0
Guests: 34
Stats
Files
Topics
Posts
Members
Newest Member
489
3,791
19,644
596
Elwood

Today's Birthdays
There are no member birthdays today.
» SmaugMuds » Codebases » SWR FUSS » bug in extract_char results i...
Forum Rules | Mark all | Recent Posts

bug in extract_char results in a crash
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 20, 2009 11:20 am   
Go to the top of the page
Go to the bottom of the page

Samsa
Fledgling
GroupMembers
Posts15
JoinedAug 29, 2008

 
I found this bug in swr1.2.

To reproduce the crash, we need two players, A and B. Player B needs to have the killer flag.

- Player A follows player B.
- Player B quits.
- Player A follows another char, himself, or quits.

To fix it, change the following line in extract_char:

if( fPull && !IS_SET( ch->act, ACT_POLYMORPHED ) )
    die_follower( ch );


by

if ( fPull && (!IS_NPC(ch) || !IS_SET(ch->act, ACT_POLYMORPHED)))
    die_follower( ch );

Post is unread #2 Aug 20, 2009 4:29 pm   
Go to the top of the page
Go to the bottom of the page

ayuri
Magician
GroupMembers
Posts239
JoinedJun 13, 2008

 
HA! Nice that it's both in SWR and FOTE in some fashion.

Just wondering if anyone's determined if the ACT_POLYMORPHED is needed in that function? When I was digging in I seen that the SMAUG side of things just nipped it in the butt by:
   if( fPull )
      die_follower( ch );


ayuri

Pages:<< prev 1 next >>