Bug: Invisible glowing items aren't supported properly
Danger: Low - Will tend to give away too much information
Discovered in: AFKMud 1.77
Found by: Valcados
Fixed by: Valcados

---

act_info.c, format_obj_to_char

Locate:

   if( fShort )
   {
      if( glowsee && !IS_IMMORTAL( ch ) )
         mudstrlcat( buf, "the faint glow of something", MSL );
      else if( obj->short_descr )
         mudstrlcat( buf, obj->short_descr, MSL );
   }
   else
   {
      if( glowsee )
         mudstrlcat( buf, "You see the faint glow of something nearby.", MSL );
      if( obj->objdesc && obj->objdesc[0] != '\0' )
         mudstrlcat( buf, obj->objdesc, MSL );
   }

Change to:

   if( fShort )
   {
      if( glowsee && ( IS_NPC(ch) || !IS_PLR_FLAG( ch, PLR_HOLYLIGHT ) ) )
         mudstrlcat( buf, "the faint glow of something", MSL );
      else if( obj->short_descr )
         mudstrlcat( buf, obj->short_descr, MSL );
   }
   else
   {
      if( glowsee && ( IS_NPC(ch) || !IS_PLR_FLAG( ch, PLR_HOLYLIGHT ) ) )
         mudstrlcat( buf, "You see the faint glow of something nearby.", MSL );
      if( obj->objdesc && obj->objdesc[0] != '\0' )
         mudstrlcat( buf, obj->objdesc, MSL );
   }

The existing glow support is good, but in some cases it would tend to reveal more than it should. It was also not setup to honor the PLR_HOLYLIGHT flag for imms.